Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Only check for username and password if driver type is mysql #54
If you choose sqlite and go through the configure process and then try to start you get this:
Workaround is to set a username and password even though not needed. This changes the check to only apply if the driver is mysql
Good catch! Thanks for fixing this.
I made just one change: to use the constants we have set up for the different db drivers, since we should've been doing that already.
Otherwise the patch looks good to me -- we just need to get your signature on the CLA and then we'll merge it!