Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add go.mod/go.sum #58

Closed
wants to merge 1 commit into from

Conversation

@sheenobu
Copy link

commented Jan 8, 2019

This could probably be separated out into two separate diffs: 1. go.mod/go.sum and 2. makefile updates. but current master and 0.7.0 is broken with go modules due to go-bindata go get failing (since there is no GOPATH). Feel free to edit/use as needed.

This fixes build issues with:

  • go-bindata, which attempted a go get ...
  • pinning ikeikeikeike/go-sitemap-generator to 1.0.1 instead of master
  • replace all go-get with go build -o tmpbin/

@sheenobu sheenobu force-pushed the sheenobu:master branch 3 times, most recently from 4090e3a to 8475ea5 Jan 8, 2019

Add go.mod/go.sum
This fixes build issues with:

 * go-bindata, which attempted a go get ...
 * pinning ikeikeikeike/go-sitemap-generator to 1.0.1 instead of master
 * replace all go-get with go build -o tmpbin/

@sheenobu sheenobu force-pushed the sheenobu:master branch from 8475ea5 to 8ca33d4 Jan 8, 2019

@SamWhited

This comment has been minimized.

Copy link

commented Jan 9, 2019

Currently in the Arch package I am having to manually override the version of some dependencies, which is not ideal. Packaging is another area where this would help a lot. I am happy to contribute or help make this possible in any way that I can if there is anything blocking this from being merged. Thanks!

P.S. the Travis failure can be fixed by using go get instead of go mod download, or by bumping the version tested against to 1.11.x.

@thebaer

This comment has been minimized.

Copy link
Member

commented Jan 10, 2019

@sheenobu Thanks for submitting this! By the way, your go-webfinger library was a big help for this project 🙂

If you don't mind splitting this into two PRs and making the Travis config change @SamWhited mentioned, that'll help a lot. Lastly, just need a quick signature on the CLA and then I'll get everything merged.

@sheenobu

This comment has been minimized.

Copy link
Author

commented Jan 10, 2019

No worries! Should we bump travis conf to 1.11?

@thebaer

This comment has been minimized.

Copy link
Member

commented Jan 10, 2019

Yep, that'll work!

@thebaer thebaer added the help wanted label Jan 26, 2019

@SamWhited

This comment has been minimized.

Copy link

commented Jan 27, 2019

Gentle ping; @sheenobu if you're not available to wrap this up, I'd be happy to rebase and get everything working. Let me know.

@sheenobu

This comment has been minimized.

Copy link
Author

commented Jan 29, 2019

please do!

@SamWhited

This comment has been minimized.

Copy link

commented Jan 29, 2019

@sheenobu I was actually forgetting, this repo requires a CLA so I probably can't make makefile changes and what not because @thebaer considers those copyrightable code. I could update the go.mod file, which a tool is doing, but I guess I can't finish this off. Sorry.

@SamWhited SamWhited referenced this pull request Feb 1, 2019
0 of 1 task complete
thebaer added a commit that referenced this pull request Apr 6, 2019
@thebaer

This comment has been minimized.

Copy link
Member

commented Apr 6, 2019

We now support Go modules, and I've used the Makefile as a starting place for a new make ci command that ensures Travis successfully builds. Thanks for the initial contribution and input, @sheenobu and @SamWhited!

@thebaer thebaer closed this Apr 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.