Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add touch icons #78

Merged
merged 2 commits into from Mar 24, 2019

Conversation

Projects
None yet
2 participants
@mrvdb
Copy link
Collaborator

commented Feb 19, 2019

These were missing.

Fix for #77

  • [X ] I have signed the CLA
Add touch icons
These were missing.

@mrvdb mrvdb referenced this pull request Feb 19, 2019

Closed

Apple icon files missing #77

@thebaer

This comment has been minimized.

Copy link
Member

commented Feb 20, 2019

Hey, good catch. We should use the WriteFreely logo (here for a light background / dark background) instead of the Write.as one.

Which one would you rather see? The logo on a light background, or on a dark one like the current Write.as logo?

@mrvdb

This comment has been minimized.

Copy link
Collaborator Author

commented Feb 21, 2019

I have no preference for a logo. I am unable to view the results as well, as I understand this is like a 'ios specific favicon' ? (i have no ios device)

@thebaer

This comment has been minimized.

Copy link
Member

commented Feb 26, 2019

Ok, no problem. Yeah, this is only for iOS. I'll put together a new icon -- I should have a device somewhere I can test it out on.

@thebaer thebaer added this to the 1.0 milestone Feb 28, 2019

Use WF "w" for touch icons
(instead of the Write.as "w")
@thebaer

This comment has been minimized.

Copy link
Member

commented Mar 24, 2019

Alright, got the WriteFreely "w" in there. Thanks again for reporting this! Merging now.

@thebaer thebaer merged commit 5a0a3ce into writeas:master Mar 24, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@mrvdb

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 25, 2019

Nice, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.