Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak Makefile for MacOS #97

Merged
merged 1 commit into from Apr 30, 2019
Merged

Tweak Makefile for MacOS #97

merged 1 commit into from Apr 30, 2019

Conversation

@dariusk
Copy link
Contributor

dariusk commented Apr 30, 2019

On my MacOS machine, global node binaries like lessc are stored in /usr/local/bin/. The current Makefile only checks for /usr/bin/ and this rectifies that error. There is probably a better way to just run which lessc and then use that path, defaulting to node_modules if that path doesn't exist, but as this is my first contribution to the project I wanted to stick with what was already there, stylistically.


  • I have signed the CLA
@dariusk dariusk changed the title Strip newlines from AP Article object HTML output, fix Strip newlines from AP Article object HTML output, tweak Makefile Apr 30, 2019
@thebaer

This comment has been minimized.

Copy link
Member

thebaer commented Apr 30, 2019

Hey, thanks for submitting this! These are both great fixes I'd like to get merged. There are just a few potential gotchas with stripping newlines that I want to discuss, so would you mind splitting this into two PRs? That way I can merge the lessc Makefile changes while we talk about the newline stuff.

@dariusk

This comment has been minimized.

Copy link
Contributor Author

dariusk commented Apr 30, 2019

@dariusk dariusk force-pushed the dariusk:master branch from ab7a079 to 91a181f Apr 30, 2019
@dariusk dariusk changed the title Strip newlines from AP Article object HTML output, tweak Makefile Tweak Makefile for MacOS Apr 30, 2019
@dariusk

This comment has been minimized.

Copy link
Contributor Author

dariusk commented Apr 30, 2019

Okay, split this. This PR is now just the lessc stuff, #98 is the newlines.

@thebaer

This comment has been minimized.

Copy link
Member

thebaer commented Apr 30, 2019

Awesome, thank you! I agree there's probably a better way to use the path from which lessc in the future (feel free to improve it anytime), but this will do the trick! Merging now.

@thebaer thebaer merged commit 601fc5d into writeas:master Apr 30, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@thebaer thebaer added this to the 0.10 milestone Apr 30, 2019
@thebaer thebaer mentioned this pull request Apr 30, 2019
1 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.