Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development Setup failed during "go get" #36

Closed
ownia opened this issue Jul 9, 2021 · 6 comments
Closed

Development Setup failed during "go get" #36

ownia opened this issue Jul 9, 2021 · 6 comments

Comments

@ownia
Copy link

@ownia ownia commented Jul 9, 2021

Describe the bug

following the guide to https://writefreely.org/docs/latest/developer/setup step to build from source and failed.

Steps to reproduce (if necessary)

run "go get -d github.com/writeas/writefreely/cmd/writefreely"
and it occurs:

➜  /usr/local/go/src go get -d github.com/writeas/writefreely/cmd/writefreely

go: downloading github.com/writeas/writefreely v0.13.1
go: found github.com/writeas/writefreely/cmd/writefreely in github.com/writeas/writefreely v0.13.1
go get: github.com/writeas/writefreely@v0.13.1: parsing go.mod:
	module declares its path as: github.com/writefreely/writefreely
	        but was required as: github.com/writeas/writefreely

Expected behavior

Application configuration

I build this on silicon arm64 macos.
go version:

➜  /usr/local/go/src go version
go version go1.15.6 darwin/amd64
@thebaer thebaer transferred this issue from writefreely/writefreely Jul 9, 2021
@thebaer
Copy link
Member

@thebaer thebaer commented Jul 9, 2021

Thanks, @ownia. Yes the repo moved, so the correct command would be:

go get -d github.com/writefreely/writefreely/cmd/writefreely

If anyone wants to fix this, please feel free! Just let us know you'd like to fix it, and then update developer/setup.md with the correct instructions. Otherwise I'll take care of it when I get a chance.

@ownia
Copy link
Author

@ownia ownia commented Jul 9, 2021

I found that the cmd at https://writefreely.org/docs/latest/developer/setup this page is

go get -d github.com/writeas/writefreely/cmd/writefreely

but at https://github.com/writefreely/documentation/blob/master/developer/setup.md it seem like a correct version

go get -d github.com/writefreely/writefreely/cmd/writefreely

So I wonder whther it needs a depoly sync in fact?

@ownia
Copy link
Author

@ownia ownia commented Jul 9, 2021

plus, after go get -d github.com/writefreely/writefreely/cmd/writefreely, I do not find a writefreely folder under $GOPATH/src/github.com, but $GOPATH/pkg/mod/github.com has writefreely and writeas.
so I run go get -u github.com/writefreely/writefreely/cmd/writefreely to check is there any build error, the output is:

# github.com/writeas/activityserve
writeas/activityserve@v0.0.0-20200409150223-d7ab3eaa4481/actor.go:457:39: not enough arguments in call to httpsig.NewSigner
	have ([]httpsig.Algorithm, string, []string, httpsig.SignatureScheme)
	want ([]httpsig.Algorithm, httpsig.DigestAlgorithm, []string, httpsig.SignatureScheme, int64)
writeas/activityserve@v0.0.0-20200409150223-d7ab3eaa4481/actor.go:524:35: not enough arguments in call to httpsig.NewSigner
	have ([]httpsig.Algorithm, string, []string, httpsig.SignatureScheme)
	want ([]httpsig.Algorithm, httpsig.DigestAlgorithm, []string, httpsig.SignatureScheme, int64)
@thebaer
Copy link
Member

@thebaer thebaer commented Jul 12, 2021

So I wonder whther it needs a depoly sync in fact?

Yes, it looks like the docs on our site weren't syncing up. Should be fixed now 👍

For the build error, that shouldn't come up if you have Go modules enabled (see writeas/activityserve#1). Can you try enabling Go modules and see if that fixes it?

@ownia
Copy link
Author

@ownia ownia commented Jul 13, 2021

For the build error, that shouldn't come up if you have Go modules enabled (see writeas/activityserve#1). Can you try enabling Go modules and see if that fixes it?

Thanks, with GO111MODULE="auto" I installed it successfully. And I think auto should be specified instead of on.

@thebaer
Copy link
Member

@thebaer thebaer commented Jul 13, 2021

Great! Yes, I think auto works best across all Go projects, but you should always be fine with on here. And I believe that's the default setting in recent versions of Go.

I'll go ahead and close this, since it looks like all the issues are resolved!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants