Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub?
to your account
Confirming the fix in #111, we discovered a different issue with followers using pubgate.
All POST requests against the Pubgate user return an error:
..Post : unsupported protocol scheme ""
It looks like we store an empty string as their inbox.
Steps to reproduce the behavior:
POSTs should go out to an actual URL and succeed.
Version or last commit:
WF commit 95215aa on branch gh100
The text was updated successfully, but these errors were encountered:
Good catch. To be sure, this is the error returned on our end? If so, what's the full log around that error look like?
Sorry, something went wrong.
Jun 03 15:32:53 mangrove rob: 2019/06/03 15:32:53 POST
Jun 03 15:32:53 mangrove rob: ERROR: 2019/06/03 15:32:53 log.go:26: Couldn't delete post! Post : unsupported protocol scheme ""
This is among a bunch of successful POSTs for the same action
I see. So looking into the code... actually we're not storing the user's shared inbox (I assume it doesn't have one). Looking at the database, we do have an inbox for that pubgate user.
So to fix this issue, we need to fix the logic in various activitypub.go funcs that compile an inboxes map to fall back to a RemoteUsers Inbox if their SharedInbox is empty. E.g. in places like this: https://github.com/writeas/writefreely/blob/95215aa39db51f9510ded34480a62fb61242c4dd/activitypub.go#L550-L557 we need to check if f.SharedInbox == "" and if so, use f.Inbox instead.
if f.SharedInbox == ""
perfect, thanks @thebaer
No problemo! If you want to tackle this fix, please feel free to assign yourself.
just testing now
Successfully merging a pull request may close this issue.