Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embedded YouTube videos cannot start at a certain time using "?start=..." #328

Closed
mjbrisebois opened this issue Jun 22, 2020 · 0 comments · Fixed by #364
Closed

Embedded YouTube videos cannot start at a certain time using "?start=..." #328

mjbrisebois opened this issue Jun 22, 2020 · 0 comments · Fixed by #364
Labels
enhancement Proposed enhancements to current behavior good first issue help wanted

Comments

@mjbrisebois
Copy link

Describe the bug

This code https://github.com/writeas/writefreely/blob/develop/postrender.go#L100-L102 (which is states the intention is to remove autoplay) makes it so that I cannot have YouTube videos start at a precise moment using ?start=....

Expected behavior

It should just remove the autoplay query parameter if that is the intention. Although I don't understand why that would happen on the blog page. It seems like something you would only want to remove on blog previews when there could be many annoying "autoplay"s triggered.

Application configuration

  • Multi-user mode
  • Database? sqlite
  • Open registration? yes
  • Federation enabled? no

Version or last commit: 4570511
@thebaer thebaer added enhancement Proposed enhancements to current behavior good first issue help wanted labels Jun 22, 2020
Obayanju added a commit to Obayanju/writefreely that referenced this issue Aug 7, 2020
@Obayanju
Fix removal of query parameters on youtube embed links
9b614bc 
This uses go's html and url parser plus regex, instead of
using only a single regex for simplicity sake. A single regex expression
might be error prone, for example, when trying to matching html entities.

Fixes writefreely#328
@Obayanju Obayanju mentioned this issue Aug 7, 2020
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Proposed enhancements to current behavior good first issue help wanted
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix removal of query parameters on youtube embed links Obayanju/writefreely
2 participants
@mjbrisebois @thebaer