Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After updating to v0.13.0 /read will not load #467

Closed
stayinside opened this issue Jun 12, 2021 · 9 comments
Closed

After updating to v0.13.0 /read will not load #467

stayinside opened this issue Jun 12, 2021 · 9 comments
Assignees
Labels
Milestone

Comments

@stayinside
Copy link

@stayinside stayinside commented Jun 12, 2021

Since updating the reader feed does not load. My reverse proxy sends a 504 and loads just hang on the debug message
[READ] Updating post cache

  • Multi-user mode
  • sqlite
  • Open registration? no
  • Federation enabled? yes
@thebaer
Copy link
Member

@thebaer thebaer commented Jun 17, 2021

Hi @stayinside, can you share some more information about your setup, as prompted in the original bug report template? For example, which database are you using?

And just to be sure, did you run writefreely db migrate after updating the binary?

@stayinside
Copy link
Author

@stayinside stayinside commented Jun 17, 2021

Oh sorry my mistake!
Updated my post, and yes I definitely ran that.
Running with the debug flag does not add any more information

@DaarkMoon
Copy link

@DaarkMoon DaarkMoon commented Jun 17, 2021

Same issue for me but there is a strange point:

Maybe the read page lock the sqlite database ?

Application configuration

  • Single mode or Multi-user mode? Multi-user mode
  • Database? sqlite
  • Open registration? no
  • Federation enabled? yes

Version or last commit: 0.13.0 (last binary released for linux amd64)

PS: I have run writefreely db migrate after updating the binary

@thebaer
Copy link
Member

@thebaer thebaer commented Jun 17, 2021

Thanks for the additional information @stayinside and @DaarkMoon -- I agree it sounds like it could be a read lock on the database. I'll try to replicate and debug more when I'm back from vacation this week. (I'm not sure what changes around the Reader query could've caused this -- it could be the additional GetCollectionAttribute call on each blog while looping through the overall Reader results.)

@bandicootdancing
Copy link

@bandicootdancing bandicootdancing commented Jun 18, 2021

Describe the bug

Writefreely is hanging when clicking on the reader. I'm not sure if crawlers/users are triggering the reader but writefreely is crashing daily since upgrading. I'm not sure if it's related but by the time I get around to restarting writefreely I see "too many open files." I've disabled the reader to see if the instance stays up.

Steps to reproduce (if necessary)

Steps to reproduce the behavior:

  1. Click on reader
  2. See [READ] Updating post cache in terminal
  3. Writefreely becomes unusable until restart

Application configuration

  • Single mode or Multi-user mode? Multi
  • Database? sqlite
  • Open registration? no
  • Federation enabled? yes

Version or last commit: 0.13.0

@thebaer thebaer added this to the 0.13.1 milestone Jun 21, 2021
@thebaer thebaer added bug and removed bug? labels Jun 25, 2021
thebaer added a commit that referenced this issue Jun 25, 2021
Fetching posts for the Reader involves an additional query on each row,
which previously ran into our connection limit to the database and caused
it to lock up. This increases the connection limit from 1 to 2, to allow
this.

This is meant to be a quick, safe fix, but there could always be a better
solution.

Fixes #467
@thebaer thebaer self-assigned this Jun 25, 2021
@thebaer thebaer linked a pull request that will close this issue Jun 25, 2021
@poVoq
Copy link

@poVoq poVoq commented Jun 26, 2021

I have a similar issue on a fresh 0.13 install (same setup as OP).

The site runs fine until I make a first post. Upon which it continues to run fine for 5 minutes or so, but the post never shows up in the /read part and soon after the entire site goes in permanent 504 timeout.

@thebaer
Copy link
Member

@thebaer thebaer commented Jun 26, 2021

Thanks @poVoq, this should be fixed in #477. If anyone else can test out that branch and verify the fix, that'd be much appreciated!

@DaarkMoon
Copy link

@DaarkMoon DaarkMoon commented Jun 28, 2021

I have build binary fom branch fix-sqlite-reader-lock and now it's work for me.

@thebaer
Copy link
Member

@thebaer thebaer commented Jun 30, 2021

Great! Just merged that fix, and we'll release v0.13.1 later today.

@thebaer thebaer closed this Jun 30, 2021
@thebaer thebaer mentioned this issue Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Linked pull requests

Successfully merging a pull request may close this issue.

5 participants