Serving ActivityPub objects

[silverpill]

Describe the bug

According to ActivityPub specification, servers should respond with ActivityStreams object representation to requests having application/ld+json; profile="https://www.w3.org/ns/activitystreams" in Accept header, but apparently only application/activity+json is supported

Servers ... MUST present the ActivityStreams object representation in response to application/ld+json; profile="https://www.w3.org/ns/activitystreams", and SHOULD also present the ActivityStreams representation in response to application/activity+json as well.

writefreely/posts.go

Line 1123 in b7f732b

if strings.Contains(accept, "application/activity+json") {

Steps to reproduce (if necessary)

curl -H 'Accept: application/ld+json; profile="https://www.w3.org/ns/activitystreams"' https://***/api/posts/***

The server returns the standard API response:

{
  "code": 200,
  "data": {
    ...
  }
}

Expected behavior

Server should return ActivityStreams object representation.

[thebaer]

Thanks for reporting this! Fixed now, and will go into v0.14.

[silverpill]

@thebaer I tried this:

curl -H 'Accept: application/ld+json; profile="https://www.w3.org/ns/activitystreams"' https://blog.writefreely.org/version-0-14

But it returns HTML, not JSON.

The header value in #766 seems to be correct though. Perhaps the change wasn't included in 0.14?

[thebaer]

Thanks for pointing that out! Looks like those previous changes only encompassed the API endpoints, and not the canonical / public URLs for blogs and posts. That's all fixed in #779.

[silverpill]

Thank you for looking into this!
Has this patch been applied to any live instance where I can test it?

[thebaer]

Yes, it's live on Write.as now!

[silverpill]

Everything working as expected. Thanks a lot

[thebaer]

Great, thank you for verifying!