Repository navigation
"Hashtags" in code blocks get parsed as hashtags #6
Description
Activity
How about this idea?
instead of using regexp for replacing hashtags, using a parser that does different passes. Like this https://github.com/russross/blackfriday/blob/master/markdown.go#L405
It would be something like this:
assign last_codeblock_end = 0
start = 0
for start < len(doc):
if start < last_codeblock_end:
ignore everything
else:
check if this is a new code block
then if not do renderingI don't think its possible to parse it using regexp, at least not with vanilla regexp, I'm not sure how different Go's regexp is from the regular expression used in theory of computation.
Just for reference, this is the code that needs changing:
https://github.com/writeas/writefreely/blob/master/postrender.go#L33Hope this helps.
Reacted by Matt BaerHow can we move forward here? This is probably less trivial than it looks. Some things which stood out to me:
- i would have thought md -> html conversion was a more or less 'solved problem' by now, what makes our conversion special?
- the md parser seems a modified version of https://github.com/russross/blackfriday correct? some details on why would be helpful
- the extracttags is coming from https://github.com/kylemcc/twitter-text-go which seems to be optimized for tweet parsing. Perhaps not the best choice for extracting hashtags in general?
@MCSH Agreed that regex isn't the right solution, and some kind of better parser is needed. Thanks for the suggestion!
- The trouble is with using regex to find hashtags in plain Markdown and just replacing them with HTML -- that method lacks the context to know instances when it shouldn't replace "hashtags", like inside code blocks
- Right, I listed the changes made in the forked repo. Mostly, it's to make the parser more strict. Changes are all based off of how people were actually using Write.as, e.g. trying to insert special formatting / characters but not wanting it to actual render some special way.
- The twitter-text-go library is the best one I've found that works with any language / character set you can throw at it. We can always switch if there's a better library out there, but I doubt any take markdown into consideration like we'd need them to.
- added a commit that references this issue
on Dec 3, 2018 I just am trying out the 0.15.1 version of WriteFreely on paper.wf instance. It looks like the hashtags in code blocks still get treated as hashtags (e.g. if you use #include in C++ code). When I read the post via Mastodon the #include is also added to the list of tags. Should this be reopened or should I open a new issue?
As reported here: https://mst3k.interlinked.me/@cadey/100673777784986480