Skip to content

HMTL being included in post Metadata, and not scrubbed when removed from post.  #83

Description

Describe the bug

When using html for inserting images, video or even just centering images, the html code is being included in the metadata desriptions. This is viewable both on google search results, and posted links to sites like Mastodon. Futhermore, deleting the HTML code from the post does not remove the html text from the metadata.

Steps to reproduce (if necessary)

Steps to reproduce the behavior:

  1. Publish a post with html code, within first few lines of post.
  2. Click on publish
  3. post link to post on site such as Mastodon. Code will show in description.

Expected behavior

Code should be ignored and not included in metadata descriptions.

Application configuration

https://write.as

  • Federation enabled? yes

Version or last commit:
https://write.as

Activity

  1. thebaer commented on Mar 13, 2019

    @thebaer
    Member

    Hey, thanks for reporting this. Right now we strip out Markdown for the post descriptions, so we'll need to strip out HTML, as well.

    As for the metadata not updating after the HTML has been removed, is that happening when you view the same post on sites like Mastodon? Or when you view source on the post itself? If it only happens on sites like Mastodon, that's likely just because it's caching the metadata.

  2. added this to the 1.0 milestone on Mar 13, 2019
  3. self-assigned this
    on Mar 14, 2019
  4. thebaer commented on Mar 14, 2019

    @thebaer
    Member

    Yeah, sounds like that's Mastodon caching the metadata. I'm not sure how to invalidate it, unfortunately... But I fixed this, so that won't happen anymore. The change should be deployed on Write.as within the next day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions