V2 migrations not run on new instance

[ghost]

Describe the bug

V2 migrations (altering the appcontent table) is not applied during init-db; migrations table claims it is V2 though.

MariaDB [writefreely]> describe appcontent;
+---------+-------------+------+-----+---------------------+-------+
| Field   | Type        | Null | Key | Default             | Extra |
+---------+-------------+------+-----+---------------------+-------+
| id      | varchar(36) | NO   | PRI | NULL                |       |
| content | mediumtext  | NO   |     | NULL                |       |
| updated | datetime    | NO   |     | current_timestamp() |       |
+---------+-------------+------+-----+---------------------+-------+

MariaDB [writefreely]> select * from appmigrations;
+---------+---------------------+--------+
| version | migrated            | result |
+---------+---------------------+--------+
|       2 | 2019-04-14 20:29:53 |        |
+---------+---------------------+--------+

Steps to reproduce (if necessary)

1. Create an empty database
2. Point config to empty database
3. writefreely -init-db

Expected behavior

V2 migrations were run and appcontent has title and content_type columns.

Application configuration

• Single mode or Multi-user mode? Multi
• Database? [mysql/sqlite] mysql
• Open registration? [yes/no] yes
• Federation enabled? [yes/no] yes

Version or last commit:
WriteFreely 0.9.0

Workaround

update appmigrations set version=1;

[thebaer]

Thanks for the report! Forgot to update the schema files 😞

I think this would be a good time to keep all schema changes in the migrations module, so we don't have to worry about this in the future. While I work on a fix, to clarify, the workaround is to first run this database query:

UPDATE appmigrations SET version=1;

Then run this command:

writefreely --migrate