Fix missing hostname when publishing via API#144
Merged
Conversation
This fixes a bug that occurred only when publishing via API and authenticating via token (rather than cookie). Previously, the instance's hostname wouldn't be added to the Collection that got passed around after retrieving the owned post, meaning an incomplete URL was returned in the API response, and federation failed due to the missing host.
This is the crucial part where the hostName is needed for federation and API clients. This change at least lets us know when we mess up like this so the issue is easier to catch in the future.
Member
Author
|
Leaving this open for a bit longer while we test |
Member
Author
|
Good to go now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug that occurred only when publishing via API and authenticating via token (rather than cookie). I noticed this while testing the new
wf-cli.Previously, the instance's hostname wouldn't be added to the
Collectionthat got passed around after retrieving the owned post, meaning an incomplete URL was returned in the API response, and federation failed due to the missing host (and thus failed key lookup).