-
-
Notifications
You must be signed in to change notification settings - Fork 337
Reader-first multi-user instances #157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This shows the Blogs page instead of the Editor to logged in users on the `/` path when the new `simple_nav` config option is enabled. Ref T680
This shows About, Reader, Log out links on backend user pages when logged in. It also adds "New post" buttons on the backend pages and blogs.
This adds a new editor template that strips away most of the customization features in the default editor and includes only: - publishing - editing - viewing word count It also restricts publishing to a user's first collection, so it's optimized for instances that only allow users to have a single collection and don't use Drafts. Ref T680 T677
i.e. current tag a user is browsing, when they are.
This adds a new config value: `chorus` that signifies an instance is more about the Reader view than individual blogs / writers. When enabled, user navigation will show on all pages, including About, Reader, and Privacy (ref T680). It also uses different collection templates that keep the instance-wide navigation at the top of the page, instead of the author's name -- again, branded more for the collective than the individual. Ref T681
instead of linking to posts only on a user's blog. Ref T681
Previously, they would've been dropped onto the Blogs page. Ref T680
This makes it possible to edit the title and introductory text at the top of the Reader view. Ref T684
This adds a Sign Up link to site navigation and shows the otherwise-landing page on /signup when in chorus mode. Ref T681
This provides easy navigation to the logged in user's posts, since there's no direct link to their blog otherwise. Ref T681
Also, refactor navigation bar template logic to be simpler and easier to understand. Ref T681
Ref T681
This shows Drafts in the SimpleNav menu, when both enabled. It also hides Drafts in the non-SimpleNav menu when disabled. Ref T679
Ref T681 T680
This prevents the link from showing when an instance lands on the sign up page anyway. Ref T681
Previously, the new pinned post link would appear in the site header, instead of the blog header.
Previously, a failed login would change the site-wide navigation so that it looked like the user was logged in, even though they weren't. This fixes that.
@robjloranger this is ready for review now. Again, this is mostly for our own purposes (things like our internal WF instance), so there are still some missing / incomplete features here. All new config options are considered experimental, so we might not address all issues with different combinations of config values -- that'll be for a later iteration. For now, I'm mostly interested in verifying that this doesn't introduce any regressions, and everything runs / builds correctly for you. Final list of changes in this PR:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything seems to check out OK. I tested various combinations of the new options.
The New Post
button is shown always if chorus
is true, did you mean that to be only when simple_nav
was true per your comment? The new Post
button is only present when this is set, so it would be more consistent.
Regarding simple_nav
, I was wondering if it looks better to remove the Logout
and separator from the user drop down menu when this is set to true, as there is now a logout link in the header. Might be a bit cleaner.
I like the bare editor, it's really clean.
Disabling drafts works, the /me/posts
endpoint still works which is good if someone has drafts and the admin changes to disabling them.
Editing the reader content also works as expected.
Failed log in attempts do not alter the navigation.
Thanks for taking a look at everything, and glad you like it!
Which
This is a great point. But I think for now, while we're still trying to get the interface right for the non-technical users choosing this layout, the redundancy is okay. |
Oh the new simple NAV style post button on the pad. Where it changes from the arrow and metadata buttons to a clean button that just say's |
Ah, yeah it's styled the same but it's actually unrelated to either of those settings -- it's just a static part of the |
This ensures the "new post" link under each blog on the user Blogs page goes to /new instead of /. Ref T681
This allows instance admins to configure an instance to be more about the collective Reader than the individual blogs.
To enable, edit your configuration file to have
chorus = true
under the[app]
section. This is still very experimental, is built to solve a specific user's needs, and will likely change in drastic ways in the near future. It builds off the work in #153, #154, and #155, and will resolve T681 when finished.