Skip to content

remove gogs/gogs/pkg/tool dependency#182

Merged
thebaer merged 3 commits intodevelopfrom
rm-gogs-pkg-tool
Sep 13, 2019
Merged

remove gogs/gogs/pkg/tool dependency#182
thebaer merged 3 commits intodevelopfrom
rm-gogs-pkg-tool

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Sep 11, 2019

this borrows some code from github.com/gogs/gogs/pkg/tool to avoid
pulling it in as a dependency, along with many other indirect deps.

closes #156


  • I have signed the CLA

this borrows some code from github.com/gogs/gogs/pkg/tool to avoid
pulling it in as a dependency, along with many other indirect deps.
@ghost ghost requested a review from thebaer September 11, 2019 19:54
@thebaer
Copy link
Copy Markdown
Member

thebaer commented Sep 13, 2019

I updated the file to include their copyright information. Otherwise I'd say that we should put this in its own package (maybe appstats?), to keep the writefreely pkg clean and make it reusable.

@ghost
Copy link
Copy Markdown
Author

ghost commented Sep 13, 2019

I'll make that change shortly

Copy link
Copy Markdown
Member

@thebaer thebaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, looks good! Thanks.

@thebaer thebaer merged commit 5310e6d into develop Sep 13, 2019
@thebaer thebaer deleted the rm-gogs-pkg-tool branch September 13, 2019 17:31
@thebaer thebaer added this to the 0.11 milestone Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Potential case-insensitive import collision

1 participant