Skip to content

allow titles for abbreviation elements#184

Merged
thebaer merged 1 commit intodevelopfrom
title-attrs
Sep 18, 2019
Merged

allow titles for abbreviation elements#184
thebaer merged 1 commit intodevelopfrom
title-attrs

Conversation

@ghost
Copy link

@ghost ghost commented Sep 18, 2019

this allows abbreviation elements to keep their title attributes when
containing special characters.

(Originally reported on the forum)


  • I have signed the CLA

this allows abbreviation elements to keep their title attributes when
containing special characters.
@ghost
Copy link
Author

ghost commented Sep 18, 2019

I double checked this allow rule still prevents common XSS attack vectors. Like closing the title attribute and inserting an onload, or closing the element entirely and injecting a new element like script. This either omits the abbreviation element entirely or just renders some of the contents as text on the page. Harmless either way.

But now titles such as "This is a title: with a sub tile" render as expected.

Copy link
Member

@thebaer thebaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@thebaer thebaer merged commit 66974dc into develop Sep 18, 2019
@thebaer thebaer deleted the title-attrs branch September 18, 2019 16:27
@thebaer thebaer added this to the 0.11 milestone Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant