Conversation
Member
|
This looks nice, but I think our default style should be as simple as possible, so it's as easy as possible to override with custom CSS. Then we can make this available as a fancier option. Here, I think we should just make the table |
Author
Member
|
Looks good, but is the CSS simple / easily to override? |
Author
|
I reworked it a bit to make it simpler to override. To change the style would require something like: article table {
border-color: new-color;
}
article table th {
font-size: 3em;
}We could change to using a class but it would be similar to override like: table.post {
border-color: new-color;
}
table.post th {
font-size: 3em;
} |
Member
|
Cool, I think that looks great 👍 |
Contributor
|
Tables look good on my end! Both Chrome (80.0.3987) and Firefox (73.0.1) show the same table styling. |
Member
|
Thanks @robjloranger and @cjeller1592! Looks good, merging now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


styling added: