-
-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add account deletion #202
add account deletion #202
Conversation
CLI only but backend supports calls from app.db.DeleteAccount already takes --delete-account user_id_number with optional --posts to also delete posts. if --posts is omitted all user posts will be updated to anonymous posts
Nice! For writefreely hosters, this will be very useful to clean out their 'registered but nothing else'-users after a while. |
After this we will likely be adding a nice button to each user page in the admin view as well |
@robjloranger Haven't had a chance to run yet, but after reading through: let's have the Also, let's have the default behavior delete all user posts -- I'm not sure people will want to leave user posts, especially because future deletion will require manual database work. Or was there a reason you had in mind for keeping posts? |
@thebaer I had the option for posts because it was mentioned in the original task, probably more for write.as though. So for now I can just remove the option to keep posts. |
this changed the CLI flag to use the username instead of the userID leaving the underlying database function as is. also now posts are all deleted with no option to skip as this is likely never needed.
Previously, it would show a 500. This also logs the real reason if it's not a "not found" error
CLI only but backend supports calls from app.db.DeleteAccount already
takes --delete-account user_id_number with optional --posts to also
delete posts. if --posts is omitted all user posts will be updated to
anonymous posts
[Describe the pull request here...]