Conversation
This includes the instance's hostname in calls to export a CSV file and PublicPost.CanonicalURL(). It also fixes a panic in that method during CSV export caused by draft posts.
ghost
reviewed
Nov 8, 2019
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
found a few issues with templates after this change, I have a fix to push already
the change to take a hostname in Post.CanonicalURL broke a few template using that function. This adds a Hostname string to the Post being passed to templates and passes it to calls to Post.CanonicalURL
ghost
approved these changes
Nov 8, 2019
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
with the change to post templates this looks good now, and confirmed working exports of csv urls.
tested reader, collection*posts, pinned and posts templates
thebaer
commented
Nov 8, 2019
Member
Author
thebaer
left a comment
thebaer
left a comment
There was a problem hiding this comment.
Ah thanks, great catch. Just one comment
|
ok all set |
Member
Author
|
Perfect 👍 Thanks for the review! Merging now. |
thebaer
added a commit
that referenced
this pull request
Nov 11, 2019
This fixes a template rendering issue caused by bad references to $.Host in pinned posts links on single-user instances. Closes #207
ghost
pushed a commit
that referenced
this pull request
Nov 11, 2019
Fix collection template issues introduced in #205
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes the instance's hostname in calls to export a CSV file and
PublicPost.CanonicalURL().It also fixes a panic in that method during CSV export caused by draft posts.