Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix URLs in CSV exports #205

Merged
merged 3 commits into from Nov 11, 2019
Merged

Fix URLs in CSV exports #205

merged 3 commits into from Nov 11, 2019

Conversation

thebaer
Copy link
Member

@thebaer thebaer commented Nov 7, 2019

This includes the instance's hostname in calls to export a CSV file and PublicPost.CanonicalURL().

It also fixes a panic in that method during CSV export caused by draft posts.

This includes the instance's hostname in calls to export a CSV file and
PublicPost.CanonicalURL().

It also fixes a panic in that method during CSV export caused by draft
posts.
@thebaer thebaer added this to the 0.11 milestone Nov 7, 2019
Copy link

@ghost ghost left a comment

found a few issues with templates after this change, I have a fix to push already

the change to take a hostname in Post.CanonicalURL broke a few template
using that function. This adds a Hostname string to the Post being
passed to templates and passes it to calls to Post.CanonicalURL
ghost
ghost approved these changes Nov 8, 2019
Copy link

@ghost ghost left a comment

with the change to post templates this looks good now, and confirmed working exports of csv urls.

tested reader, collection*posts, pinned and posts templates

Copy link
Member Author

@thebaer thebaer left a comment

Ah thanks, great catch. Just one comment

posts.go Outdated Show resolved Hide resolved
@ghost
Copy link

ghost commented Nov 9, 2019

ok all set

@thebaer
Copy link
Member Author

thebaer commented Nov 11, 2019

Perfect 👍 Thanks for the review! Merging now.

@thebaer thebaer merged commit a65917a into develop Nov 11, 2019
2 checks passed
@thebaer thebaer deleted the fix-csv-export branch Nov 11, 2019
thebaer added a commit that referenced this issue Nov 11, 2019
This fixes a template rendering issue caused by bad references to $.Host
in pinned posts links on single-user instances.

Closes #207
ghost pushed a commit that referenced this issue Nov 11, 2019
Fix collection template issues introduced in #205
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant