Prevent failed requests on failed user silence check #215
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids requests completely failing when a user suspension check fails, such as when
IsUserSuspended()
indicates that a "user isn't found".There's still some work to do. For example, not-found pages (like
/siteinfo.json
) previously showed:Before this fix, they'd show a "Server error" page and a 500.
With this fix, they show:
(and erroneously send two status headers).