Prevent failed requests on failed user silence check by thebaer · Pull Request #215 · writefreely/writefreely

thebaer · 2019-11-28T00:38:44Z

This avoids requests completely failing when a user suspension check fails, such as when IsUserSuspended() indicates that a "user isn't found".

There's still some work to do. For example, not-found pages (like /siteinfo.json) previously showed:

{"error": "Post not found."}

Before this fix, they'd show a "Server error" page and a 500.

With this fix, they show:

{"error": "Post not found."}<!DOCTYPE HTML>
<html>
	<head>
		<title>Page not found &mdash; WF MySQL Multi?</title>
		...

(and erroneously send two status headers).

This also saves a user suspension check when a post isn't found.

thebaer · 2019-12-18T02:01:15Z

Actually, previously mentioned issue isn't a regression. We'll need to do some refactoring to fix the issue, but that's out of scope here.

Made one more change that prevents an unnecessary log for the user silence check.

Prevent failed requests on failed user silence check

44a6703

thebaer added this to the 0.11.2 milestone Nov 28, 2019

thebaer marked this pull request as ready for review December 18, 2019 01:57

Suppress "user not found" log when post not found

cfea887

This also saves a user suspension check when a post isn't found.

thebaer merged commit 8dc1ef0 into hotfix-0.11.2 Dec 18, 2019

thebaer deleted the prevent-fail-on-suspend-check branch December 18, 2019 02:13

thebaer mentioned this pull request Dec 18, 2019

v0.11.2 hotfix #224

Merged

Navigation Menu