Refactor CLI#261
Merged
Merged
Conversation
…ation and bash complete
Member
|
Thanks for working on this! It'll still be a while before I can fully test / review, but wanted to mention that I am definitely interested in merging this. |
thebaer
requested changes
Mar 2, 2020
Member
thebaer
left a comment
There was a problem hiding this comment.
Thanks again for making these changes! Looking forward to getting this merged.
Overall everything seems great, functionally -- and I appreciate the effort to keep this backward-compatible! I mostly propose some naming changes, and noticed some examples that need updating. Otherwise, might need to run go fmt on some files. With those changes, this should be good to go!
Contributor
Author
|
@thebaer thanks for feedback. I've just pushed requested changes :) |
Member
|
Thanks for the quick fixes! Looks great 👍 merging now. |
thebaer
approved these changes
Mar 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👋 Hey, I know this is kinda a big PR and I'm thankful for you taking the time to even consider it. First, I want to say I understand that if this doesn't align with the current goal of the project that it may be closed, and that's totally ok with me.
Currently the CLI uses flags for both commands and options, this refactor switches it out to a format that allows for bashcompletion built in, and can auto-generate manpages.
For legacy sake, previous style of working with CLI still exists.
If the previous style of using only flags for everything is preferable, then this PR can be changed to still use
urfave/cli, but still be flag only and would still provide the benefits of the refactored code style.Please let me know if you have any questions.
Example help output: