-
-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor CLI #261
Refactor CLI #261
Conversation
…ation and bash complete
Thanks for working on this! It'll still be a while before I can fully test / review, but wanted to mention that I am definitely interested in merging this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for making these changes! Looking forward to getting this merged.
Overall everything seems great, functionally -- and I appreciate the effort to keep this backward-compatible! I mostly propose some naming changes, and noticed some examples that need updating. Otherwise, might need to run go fmt
on some files. With those changes, this should be good to go!
@thebaer thanks for feedback. I've just pushed requested changes :) |
Thanks for the quick fixes! Looks great 👍 merging now. |
👋 Hey, I know this is kinda a big PR and I'm thankful for you taking the time to even consider it. First, I want to say I understand that if this doesn't align with the current goal of the project that it may be closed, and that's totally ok with me.
Currently the CLI uses flags for both commands and options, this refactor switches it out to a format that allows for bashcompletion built in, and can auto-generate manpages.
For legacy sake, previous style of working with CLI still exists.
If the previous style of using only flags for everything is preferable, then this PR can be changed to still use
urfave/cli
, but still be flag only and would still provide the benefits of the refactored code style.Please let me know if you have any questions.
Example help output: