Skip to content

Fix Novel pagination - #272

Merged
thebaer merged 4 commits into
developfrom
novelfix
Mar 27, 2020
Merged

Fix Novel pagination#272
thebaer merged 4 commits into
developfrom
novelfix

Conversation

@cjeller1592

@cjeller1592 cjeller1592 commented Feb 28, 2020

Copy link
Copy Markdown
Contributor

Before, last page of blogs set to "Novel" would show "Newer" link at bottom of page instead of "Previous." PR fixes this and now shows "Previous."

  • I have signed the CLA

@thebaer thebaer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I tested on a Novel format blog, on the last page the "Previous" link showed up on the right side, instead of the left, as it is on previous blog pages. Just need to make the following changes to fix that logic and clean things up.

Comment thread templates/collection.tmpl Outdated
Comment thread templates/collection.tmpl Outdated
Comment thread templates/chorus-collection.tmpl
@thebaer thebaer added this to the 0.12 milestone Mar 27, 2020
@thebaer

thebaer commented Mar 27, 2020

Copy link
Copy Markdown
Member

Looks great! Thanks for fixing this @cjeller1592, and congrats on your first code contribution to WriteFreely! 🎉

@thebaer
thebaer merged commit 8ad04c5 into develop Mar 27, 2020
@thebaer
thebaer deleted the novelfix branch March 27, 2020 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants