Private instance cleanup #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(that is, hide the footer nav link when logged out)
This moves logic for determining whether or not to show a "Sign up" page on /signup (i.e. because the `/` route shows another, non-signup page) into the AppCfg.SignupPath() method. It also changes various signup links to use this value.
|
Looks good! Really like having the "Reader" link removed in the footer and "Log in" as the default landing page. Definitely clears things up for private instances. |
|
Merging now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves things a bit on private instances.
This isn't publicly visible, so as in the header, we now also hide this in the footer.
Private instances are only meant for registered users, and are often closed or invite-only, making the current landing page kind of pointless (and potentially confusing). This remedies that by putting the login form first, while of course still linking to the signup page if an instance has open registrations.