-
-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Gitlab OAuth #277
Add Gitlab OAuth #277
Conversation
2128b86
to
1e65a63
Compare
1e65a63
to
5e02e89
Compare
173a2c8
to
c292512
Compare
I have fixed the issues and can now successfully log in using GitLab OAuth as the authentication method |
Some things I'm wondering about:
Thoughts? |
I would prefer this, but I wasn't sure if the API server could be a separate URL to the instance. Does anyone know if that is possible?
Good idea. Will do |
I'm not sure. But if we don't hear otherwise, I think we can go ahead and implement it that way now. If we pick a good name for the config field, we can always re-add the fields for specific endpoints in the future, if they turn out to be necessary.
Awesome, sounds good. Of course, it'd probably be good to fall back to some kind of default string if there's none configured. |
There isn't any reason it can't be separate. The only consideration is making sure that we're not hardcoding any gitlab.com URLs so people with private/self-hosted instances can use it. |
Done
Defaults to GitLab if not configured |
865805d
to
ba37855
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comments on the field names to keep things tidy. Otherwise this looks good to me!
ba37855
to
26b6ed5
Compare
Fixed |
Thanks @paddatrapper and @ngerakines! Merging now. |
Adds GitLab support to the OAuth authentication structure.
It is discussed here. Currently clicking on the 'Login with GitLab' button results in a 404 error.