Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Gitea OAuth login and account management. #293

Merged
merged 6 commits into from Aug 13, 2020

Conversation

@gytisrepecka
Copy link
Contributor

@gytisrepecka gytisrepecka commented Apr 3, 2020

Added Gitea OAuth login and account management functionality based on Matt's guidelines.


  • I have signed the CLA
@thebaer thebaer added this to the 0.13 milestone Apr 15, 2020
oauth_gitea.go Outdated Show resolved Hide resolved
@cjeller1592
Copy link
Contributor

@cjeller1592 cjeller1592 commented Apr 16, 2020

Got it working on my instance @gytisrepecka! Just had an issue during set up that I lay out in a comment. Otherwise works great from a user perspective!

@gytisrepecka
Copy link
Contributor Author

@gytisrepecka gytisrepecka commented Apr 20, 2020

If possible, pull sources once again and try building:

go get -d -u -v code.gyt.is/writefreely
cd ~/go/src/code.gyt.is/writefreely
git checkout oauth-gitea

@cjeller1592
Copy link
Contributor

@cjeller1592 cjeller1592 commented Apr 20, 2020

If possible, pull sources once again and try building:

go get -d -u -v code.gyt.is/writefreely
cd ~/go/src/code.gyt.is/writefreely
git checkout oauth-gitea

Just did this & got Gitea OAuth login working on my instance with the added host in the config. Thanks for the additions @gytisrepecka!

@gytisrepecka
Copy link
Contributor Author

@gytisrepecka gytisrepecka commented Apr 23, 2020

Merged current develop branch and resolved pages/login.tmpl conflict.

This version is running live on fedi.dev.

Copy link
Member

@thebaer thebaer left a comment

Everything looks good! Just need to run go fmt on these Go files and we can get this merged.

@thebaer
Copy link
Member

@thebaer thebaer commented Aug 12, 2020

Thanks for your patience on my review -- just some quick formatting needed and we can get this in.

@gytisrepecka
Copy link
Contributor Author

@gytisrepecka gytisrepecka commented Aug 13, 2020

Performed formatting:

$ gofmt -w account.go
$ gofmt -w config/config.go
$ gofmt -w oauth.go
$ gofmt -w oauth_gitea.go
$ gofmt -w routes.go

Please take a look if there's something else.

Copy link
Member

@thebaer thebaer left a comment

Looks good! Thanks for your great work on this.

@thebaer thebaer merged commit b2382b5 into writefreely:develop Aug 13, 2020
@thebaer thebaer mentioned this pull request Aug 19, 2020
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants