Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop private and protected blogs from federating #431

Conversation

@Dak425
Copy link
Contributor

@Dak425 Dak425 commented Jan 27, 2021

Fixes #403


  • [ x] I have signed the CLA
@Dak425
Copy link
Contributor Author

@Dak425 Dak425 commented Feb 6, 2021

@thebaer @robjloranger Pull request needs reviewed and merged

Copy link
Contributor

@thebaer thebaer left a comment

This looks good! Only one change I'd suggest: let's move this logic before the log.Info() calls above, so debug messages are correct.

@thebaer
Copy link
Contributor

@thebaer thebaer commented Apr 6, 2021

With these changes, we can also clean up / de-duplicate some logic around the various federatePost() calls throughout the app, like here: https://github.com/writeas/writefreely/blob/2c1d3a51af8a0bd0dc11d86a7e0e4fab46b672ff/posts.go#L619-L621

but I'd say that's optional to include in this PR. You can make those changes here if you'd like, but otherwise we'll get this merged after the previously mentioned changes are made.

@Dak425
Copy link
Contributor Author

@Dak425 Dak425 commented Apr 7, 2021

With these changes, we can also clean up / de-duplicate some logic around the various federatePost() calls throughout the app, like here: https://github.com/writeas/writefreely/blob/2c1d3a51af8a0bd0dc11d86a7e0e4fab46b672ff/posts.go#L619-L621

but I'd say that's optional to include in this PR. You can make those changes here if you'd like, but otherwise we'll get this merged after the previously mentioned changes are made.

I think cleaning up the redundant logic can be its own issue. If anything I'll do that one as well.

@Dak425
Copy link
Contributor Author

@Dak425 Dak425 commented Apr 7, 2021

This looks good! Only one change I'd suggest: let's move this logic before the log.Info() calls above, so debug messages are correct.

Ah true that makes more sense, change has been made.

@thebaer
Copy link
Contributor

@thebaer thebaer commented Apr 7, 2021

I think cleaning up the redundant logic can be its own issue. If anything I'll do that one as well.

Sounds great!

@thebaer
thebaer approved these changes Apr 7, 2021
Copy link
Contributor

@thebaer thebaer left a comment

Looks good to me, thanks!

@thebaer thebaer added this to the 0.13 milestone Apr 7, 2021
@thebaer thebaer merged commit 4228761 into writefreely:develop Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

2 participants