Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Gopher collections query #501

Merged
merged 1 commit into from
Sep 29, 2021
Merged

Fix Gopher collections query #501

merged 1 commit into from
Sep 29, 2021

Conversation

StJudeWasHere
Copy link

Accessing to the Writefreely instance via Gopher throws this error:

ERROR: 2021/08/05 13:47:47 database.go:1693: Failed selecting public collections: ambiguous column name: id
ERROR: 2021/08/05 13:47:47 handle.go:990: failed: Couldn't retrieve public collections.

Instead of changing it to ORDER BY c.id it seems to make more sense ordering the collection by title instead.


  • I have signed the CLA

@thebaer thebaer added this to the 0.13.2 milestone Sep 29, 2021
@thebaer
Copy link
Member

thebaer commented Sep 29, 2021

Thanks for submitting this fix!

At first, I wasn't sure if it made the most sense to change what we're actually sorting by. But I agree, sorting by title makes a lot of sense. Merging now!

@thebaer thebaer changed the base branch from develop to hotfix-0.13.2 September 29, 2021 16:37
@thebaer thebaer merged commit 6e5f7e8 into writefreely:hotfix-0.13.2 Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants