Skip to content

Add touch icons - #78

Merged
thebaer merged 2 commits into
writefreely:masterfrom
mrvdb:apple-icons
Mar 24, 2019
Merged

thebaer merged 2 commits into
writefreely:masterfrom
mrvdb:apple-icons

Conversation

@mrvdb

@mrvdb mrvdb commented Feb 19, 2019

Copy link
Copy Markdown
Collaborator

These were missing.

Fix for #77

  • [X ] I have signed the CLA

These were missing.
@mrvdb mrvdb mentioned this pull request Feb 19, 2019
@thebaer

thebaer commented Feb 20, 2019

Copy link
Copy Markdown
Member

Hey, good catch. We should use the WriteFreely logo (here for a light background / dark background) instead of the Write.as one.

Which one would you rather see? The logo on a light background, or on a dark one like the current Write.as logo?

@mrvdb

mrvdb commented Feb 21, 2019

Copy link
Copy Markdown
Collaborator Author

I have no preference for a logo. I am unable to view the results as well, as I understand this is like a 'ios specific favicon' ? (i have no ios device)

@thebaer

thebaer commented Feb 26, 2019

Copy link
Copy Markdown
Member

Ok, no problem. Yeah, this is only for iOS. I'll put together a new icon -- I should have a device somewhere I can test it out on.

@thebaer thebaer added this to the 1.0 milestone Feb 28, 2019
(instead of the Write.as "w")
@thebaer

thebaer commented Mar 24, 2019

Copy link
Copy Markdown
Member

Alright, got the WriteFreely "w" in there. Thanks again for reporting this! Merging now.

@thebaer
thebaer merged commit 5a0a3ce into writefreely:master Mar 24, 2019
@mrvdb

mrvdb commented Mar 25, 2019

Copy link
Copy Markdown
Collaborator Author

Nice, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants