Resolve an edge case where last language has error#81
Merged
thebaer merged 1 commit intowritefreely:masterfrom Mar 6, 2019
Merged
Resolve an edge case where last language has error#81thebaer merged 1 commit intowritefreely:masterfrom
thebaer merged 1 commit intowritefreely:masterfrom
Conversation
If there are multiple language blocks on a page, we set the onload on the last one to load all highlighting at once. If the last language block has an error, the onload would never fire and thus all blocks would not be highlighted. The simplest resolution is to fire the callback regardless. We've already loaded everything so running the callback is not causing any performance hit which is relevant I think.
Member
|
Thanks -- for my testing, do you have an example post where an error might happen on the last language block? |
Collaborator
Author
|
[Matt Baer]:
Thanks -- for my testing, do you have an example post where an error might happen
on the last language block?
Yes,
https://qua.name/debug/test.md will fail on current master
https://qua.name/debug/test renders properly (patch already applied)
|
Member
|
Perfect. Good catch, and thanks for the fix! Merging now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If there are multiple language blocks on a page, we set the
onload on the last one to load all highlighting at once.
If the last language block has an error, the onload would
never fire and thus all blocks would not be highlighted.
The simplest resolution is to fire the callback regardless. We've
already loaded everything so running the callback is not causing any
performance hit which is relevant I think.