Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the build in Docker after enabling go modules #95

Merged
merged 2 commits into from
Apr 19, 2019

Conversation

kaiyou
Copy link
Collaborator

@kaiyou kaiyou commented Apr 19, 2019

This fixes #93 in the context of a Docker build.

Enabling go modules requires that GO111MODULE is set, so
we set it as an environment variable in the Dockerfile.

Also, go-bindata is meant to be installed globally, so we
force the install before enabling Go modules. Also, we update
Go to 1.12 to fix a couple module builds.

  • I have signed the CLA

kaiyou added 2 commits April 19, 2019 12:55
Enabling go modules requires that GO111MODULE is set, so
we set it as an environment variable in the Dockerfile.

Also, go-bindata is meant to be installed globally, so we
force the install before enabling Go modules. Also, we update
Go to 1.12 to fix a couple module builds.
@thebaer thebaer added this to the 0.9.1 milestone Apr 19, 2019
@thebaer
Copy link
Member

thebaer commented Apr 19, 2019

Awesome, thank you! This looks good to me.

On a related note, would you be interested in helping write the basic documentation for upgrading WF when using Docker (writefreely/documentation#2)? We could use some help in that area.

@thebaer thebaer merged commit fdbefa8 into writefreely:master Apr 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Build fails on sitemap.go
2 participants