Tweak Makefile for MacOS #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dariusk
changed the title
|
Hey, thanks for submitting this! These are both great fixes I'd like to get merged. There are just a few potential gotchas with stripping newlines that I want to discuss, so would you mind splitting this into two PRs? That way I can merge the |
|
No problem. Will do shortly.
…On Tue, Apr 30, 2019, 12:18 PM Matt Baer ***@***.***> wrote:
Hey, thanks for submitting this! These are both great fixes I'd like to
get merged. There are just a few potential gotchas with stripping newlines
that I want to discuss, so would you mind splitting this into two PRs? That
way I can merge the lessc Makefile changes while we talk about the
newline stuff.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#97 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AACBBVVA2UHMLWLUIRB2BQDPTCLPBANCNFSM4HJO4PDQ>
.
|
dariusk
changed the title
|
Okay, split this. This PR is now just the |
|
Awesome, thank you! I agree there's probably a better way to use the path from |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my MacOS machine, global node binaries like
lesscare stored in/usr/local/bin/. The current Makefile only checks for/usr/bin/and this rectifies that error. There is probably a better way to just runwhich lesscand then use that path, defaulting tonode_modulesif that path doesn't exist, but as this is my first contribution to the project I wanted to stick with what was already there, stylistically.