fix(parser): text signal hardening — noise-prefix strip + joined-prefix lookahead#70
Merged
Merged
Conversation
…ed text without space
📝 WalkthroughWalkthroughThis PR hardens the plaintext parser's text signal classification with two distinct fixes: (1) stripping noise prefixes (closing brackets, placeholders) that prevent structural keyword matching, and (2) loosening regex patterns and prefix stripping to handle joined prefixes where numbering or letters attach directly to content without whitespace. ChangesText signal hardening
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
3 tasks
thewrz
added a commit
that referenced
this pull request
May 18, 2026
Status table: add 1c-iii..1c-viii and 1c-sec-i/ii rows covering PRs #69 #70 #71 #72 #74 #75 #76. Updates 'Active development' subtitle to reflect Phase 1c being complete. Parsing section: add plaintext signal hardening (#70), parse-anomaly warnings (#75), and DOCX resilience suite (#72) bullets. MCP section: note POST /mcp rate limiting (#69). Not Yet Built: strike completed items (DOCX cross-ref extraction in PR #76, parse worker concurrency cap in PR #71). Add new known gap: REST persistTree ignores extracted refs (follow-up to #53).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
],]],[_____]noise prefixes from lines before signal cascade — fixes UFGS specifier-note bracket bleed where] PART 2 PRODUCTSwas silently classified ascontinuationARTICLE_REandPR_SIGNALS(pr1, pr2) to accept joined prefixes with no space — fixes CPI export pattern1.3QUALITY,B.Included,1.Manufacturersfalling tocontinuation(?=\S)lookahead for ARTICLE_RE (digit-letter boundary has no\b) and(?=[^\d\s])for PR2 to prevent1.1bare from matching as pr2Test plan
Closes #67
Summary by CodeRabbit
Tests
Bug Fixes
Test plan results
pnpm test src/parser/text/signals.test.ts— 31 tests (9 new + 22 prior) passedpnpm test— 432 tests passed, no regressionspnpm lint— ESLint + tsc + prettier clean