Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code refactoring #26

Closed
rkttu opened this issue Sep 24, 2020 · 0 comments
Closed

Code refactoring #26

rkttu opened this issue Sep 24, 2020 · 0 comments
Assignees
@rkttu
Labels
quality improvements Make code quality better
Milestone
1.0

Comments

@rkttu
Copy link
Contributor

rkttu commented Sep 24, 2020 •
edited
Loading

Some improvements

  • Release ID can be changed into a string at any time. It would be better to compare the build number of OS version.
  • Models directory should contains valid EF model class only; Constants definitions are not suitable on this namespace.
    • Also I need to add directory roadmap documentation file for future contributors.
  • Duplicated implementations need to be consolidated into one implementation. Temporarily, I restored my original WslHelper class to resolve build errors.
@rkttu rkttu added the enhancement New feature or request label Sep 24, 2020
@rkttu rkttu added this to the 1.0 milestone Sep 24, 2020
@rkttu rkttu self-assigned this Sep 24, 2020
@rkttu rkttu changed the title Better version comparing methodology Code refactoring Sep 24, 2020
@rkttu rkttu added quality improvements Make code quality better and removed enhancement New feature or request labels Sep 24, 2020
@rkttu rkttu closed this as completed Mar 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rkttu rkttu

Labels
quality improvements Make code quality better
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
1 participant
@rkttu