Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [#268] do not validate URL when skip flag is used #301

Merged
merged 1 commit into from
Mar 10, 2024

Conversation

JaZo
Copy link
Contributor

@JaZo JaZo commented Jan 11, 2024

Description

I stumbled upon #268 and saw you added the -s, --skip-validation-check flag. I checked the fix, but if I interpret the code correctly, it still does validate the URL, but now it just ignores the result. This does not fix the issue with one-time URL's described in #268 (comment). The name of the flag also suggests it completely skips the check instead of ignoring the result, so that's what I changed it into.

Types of changes

Breaking change (fix or feature that would cause existing functionality to not work as expected) are no longer accepted

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have read Code of Conduct and Contributing documentations.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@JaZo JaZo changed the title fix: [268] do not validate URL when skip flag is used fix: [#268] do not validate URL when skip flag is used Jan 11, 2024
@patrick330602 patrick330602 merged commit 4ee2c0c into wslutilities:dev/master Mar 10, 2024
@patrick330602 patrick330602 mentioned this pull request Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants