Create Secure Parser for Unmarshalling SP File Content #3472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hisanhunais
requested review from
nilasini,
omindu,
pamodaaw,
sachiniWettasinghe,
ShanikaWickramasinghe and
thanujalk
as code owners
|
PR builder started |
ashensw
reviewed
Apr 12, 2021
| + Constants.EXTERNAL_PARAMETER_ENTITIES_FEATURE + " or " + Constants.LOAD_EXTERNAL_DTD_FEATURE | ||
| + " or secure-processing."); | ||
| } | ||
| //Creating source object using the secure parser |
There was a problem hiding this comment.
Suggested change
| //Creating source object using the secure parser | |
| // Creating source object using the secure parser. |
There was a problem hiding this comment.
Fixed with 9dcda46
| //Creating source object using the secure parser | ||
| Source xmlSource = new SAXSource(spf.newSAXParser().getXMLReader(), | ||
| new InputSource(new StringReader(spFileContent.getContent()))); | ||
| //Performing unmarshall operation by passing the generated source object to the unmarshaller |
There was a problem hiding this comment.
Suggested change
| //Performing unmarshall operation by passing the generated source object to the unmarshaller | |
| // Performing unmarshall operation by passing the generated source object to the unmarshaller. |
There was a problem hiding this comment.
Fixed with 9dcda46
|
PR builder completed |
|
PR builder started |
|
PR builder completed |
jenkins-is-staging
approved these changes
Apr 16, 2021
There was a problem hiding this comment.
Approving the pull request based on the successful Jenkins job https://jenkins-support-all.wso2.com/jenkins/job/DEV_PR_BUILDER/1207/, started by ,
ashensw
approved these changes
Apr 18, 2021
This was referenced Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes in this pull request
Approach
Related PRs
https://github.com/wso2-support/carbon-identity-framework/pull/1550