Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix XSS vulnerability in registry advanced search #404

Merged
merged 2 commits into from Nov 10, 2022

Conversation

Yasasr1
Copy link
Contributor

@Yasasr1 Yasasr1 commented Nov 2, 2022

Following request parameters are encoded to fix a reflected XSS vulnerability in advancedSearch.jsp

  • mediaType
  • rightOp
  • leftOp
  • rightPropertyValue
  • leftPropertyValue

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/3378060905

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/3378060905
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/3383297182

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/3383297182
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/3383297182

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/3383297182
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/3391317383

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/3391317383
Status: failure

@Yasasr1
Copy link
Contributor Author

Yasasr1 commented Nov 4, 2022

PR builder is failing because of different intermittent test failures. A local build was successful
run - 1

INFO] Results:
 [INFO] 
 [ERROR] Failures: 
 [ERROR] org.wso2.identity.integration.test.rest.api.user.application.v1.UserDiscoverableApplicationFailureTest.testEnd(org.wso2.identity.integration.test.rest.api.user.application.v1.UserDiscoverableApplicationFailureTest)
 [ERROR] org.wso2.identity.integration.test.rest.api.user.application.v1.UserDiscoverableApplicationSuccessTest.testEnd(org.wso2.identity.integration.test.rest.api.user.application.v1.UserDiscoverableApplicationSuccessTest)
 [ERROR] org.wso2.identity.integration.test.rest.api.user.application.v1.UserDiscoverableApplicationSuccessTest.testStart(org.wso2.identity.integration.test.rest.api.user.application.v1.UserDiscoverableApplicationSuccessTest)
 [ERROR] org.wso2.identity.integration.test.rest.api.user.challenge.v1.UserMeNegativeTest.testConclude(org.wso2.identity.integration.test.rest.api.user.challenge.v1.UserMeNegativeTest)
 [ERROR] UserSessionAdminSuccessTest.testConclude:96 NullPointer
 [ERROR] UserSessionMeSuccessTest.testConclude:77 NullPointer
 [ERROR] UserSessionMeSuccessTest>UserSessionTest.testInitData:134->UserSessionTest.createServiceProvider:231 » Remote
 [ERROR] org.wso2.identity.integration.test.scim2.SCIM2MeTestCase.testCreateMe(org.wso2.identity.integration.test.scim2.SCIM2MeTestCase)
 [ERROR] org.wso2.identity.integration.test.scim2.SCIM2UserTestCase.testFilterUser(org.wso2.identity.integration.test.scim2.SCIM2UserTestCase)
 [INFO]

run - 2

INFO] Results:
 [INFO] 
 [ERROR] Failures: 
 [ERROR] SelfRegisterTestCase.testSelfRegister:81 Self register user successful expected:<201> but was:<409>
 [ERROR] SelfRegisterTestCase.testSelfRegisterWithExistingUsername:89 Self register user already exists expected:<409> but was:<201>
 [INFO] 

run - 3

[INFO] Results:
 [INFO] 
 [ERROR] Failures: 
 [ERROR] UserSessionAdminSuccessTest.testConclude:96 NullPointer
 [ERROR] UserSessionAdminSuccessTest>UserSessionTest.testInitData:134->UserSessionTest.createServiceProvider:231 » Remote
 [INFO] 

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/3435496281

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/3435496281
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/3435496281

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/3435496281
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/3436158093

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/3436158093
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/3436158093

@inthirakumaaran inthirakumaaran merged commit 0c827cc into wso2:master Nov 10, 2022
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants