Skip to content
This repository

Update to index choices from 1 #242

Closed
josephwright opened this Issue July 25, 2012 · 6 comments

4 participants

Joseph Wright Will Robertson Khaled Hosny Joel C. Salomon
Joseph Wright

The latest l3kernel update switches choice indexing from 0 to 1. This means that any use of \l_keys_choice_int needs to be updated. A quick sweep over how this is used in unicode-math suggests simply search-and-replacing with \l_keys_choice_int \or does the trick.

Will Robertson
Owner
wspr commented July 26, 2012

Sorry again for this. I don't really like the way I've done this coding after all. I've revamped this with some internal syntax so instead of what's there currently (using either .choice: or .generate_choices:n, I can write:

\um_keys_choices:nn {vargreek-shape}
 {
  {{unicode} {\bool_set_false:N \g_um_texgreek_bool}}
  {{TeX}     {\bool_set_true:N  \g_um_texgreek_bool}}
 }

Would like to remove the double braces, but that's just syntactic sugar. I find this easier to read, but obviously it's a perversion of l3keys.

Will Robertson
Owner
wspr commented July 26, 2012

Ah, also there is \peek_ code in unicode-math that needs updating. Naughtily, I'm just switching it over to \__peek_ for now :(

Joseph Wright

I have a similar issue in siunitx, which suggests to me we should fix things in l3token: one for another place :-)

Will Robertson
Owner
wspr commented July 27, 2012

Hopefully fixed in v0.7a on its way to CTAN

Will Robertson wspr closed this July 27, 2012
Khaled Hosny
Collaborator

I see the new tag but no commits to master, did you forget to push the commits?

Joel C. Salomon

@khaledhosny, the commits were pushed, but not on the master branch; see https://github.com/wspr/unicode-math/commits/v0.7a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.