Permalink
Commits on Oct 13, 2010
  1. Convert all Intel i810 boards to CAR.

    uwehermann committed with uwe Oct 13, 2010
     - Drop "select ROMCC" from the boards, as well as early_mtrr stuff.
    
     - Add "select CACHE_AS_RAM" to socket_PGA370/Kconfig, as well as the
       usual DCACHE_RAM_BASE and DCACHE_RAM_SIZE variables.
    
     - In socket_PGA370/Makefile.inc add:
       cpu_incs += $(src)/cpu/intel/car/cache_as_ram.inc
    
     - Other smaller related fixes.
    
    Abuild-tested and boot-tested on MSI MS-6178.
    
    Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
    Acked-by: Peter Stuge <peter@stuge.se>
    
    
    
    git-svn-id: svn://coreboot.org/coreboot/trunk@5949 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
  2. Enable or disable the power button in Kconfig

    Peter Stuge committed with stuge Oct 13, 2010
    Some mainboards need to disable the power button to avoid turning off
    right after being turned on, while other boards ship with a jumper over
    the power button and should allow the user to configure the behavior.
    
    This adds infrastructure in the form of four mutually exclusive options
    which can be selected in a mainboard Kconfig (power button forced on/off,
    and user-controllable with default on/off) and one result bool which
    source code can test. (Enable the button or not.)
    
    The options have been implemented in CS5536 code and for all mainboards
    which select SOUTHBRIDGE_AMD_CS5536, but should be used also by other
    chipsets where applicable. Note that if chipset code uses the result
    bool ENABLE_POWER_BUTTON, then every board using that chipset must
    select one out of the four control options in order to build.
    
    All touched boards should have unchanged behavior, except
    pcengines/alix1c, traverse/geos and lippert/hurricane-lx where the
    power button can now be configured by the user.
    
    Build tested for alix1c, alix2d, hurricane-lx and wyse-s50. Confirmed
    to work as advertised on alix1c both with button enabled and disabled.
    
    Includes additional traverse/geos changes from Nathan and
    lippert/hurricane-lx changes from Jens to correctly use the new
    feature on those boards.
    
    Signed-off-by: Peter Stuge <peter@stuge.se>
    Acked-by: Aurelien Guillaume <aurelien@iwi.me>
    Acked-by: Nils Jacobs <njacobs8@hetnet.nl>
    
    
    git-svn-id: svn://coreboot.org/coreboot/trunk@5948 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
  3. Fix a stupid bug in rs780 and rs690 code.

    Zheng Bao committed with zbao Oct 13, 2010
    Signed-off-by: Zheng Bao <zheng.bao@amd.com>
    Acked-by: Scott Duplichan <scott@notabs.org>
    
    
    git-svn-id: svn://coreboot.org/coreboot/trunk@5947 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
  4. Trivial. Clean up code and add some comments.

    Zheng Bao committed with zbao Oct 13, 2010
    Signed-off-by: Zheng Bao <zheng.bao@amd.com>
    Acked-by: Zheng Bao <zheng.bao@amd.com>
    
    
    
    git-svn-id: svn://coreboot.org/coreboot/trunk@5946 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
Commits on Oct 12, 2010
  1. Add missing include of model_6bx for slot_1.

    Keith Hui committed with uwe Oct 12, 2010
    I could no longer boot my P3B-F with my Tualeron and r5938. Dies with
    "unknown CPU". I believe it will happen with any Slot 1 440BX boards
    that supports model_6bx CPUs.
    
    I need to make the change below to make it work. abuild tested. Boot
    tested on P2B-LS and P3B-F.
    
    Signed-off-by: Keith Hui <buurin@gmail.com>
    Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
    
    
    
    git-svn-id: svn://coreboot.org/coreboot/trunk@5945 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
  2. Move translate_spd_to_i82810[] from .h to .c file (trivial).

    uwehermann committed with uwe Oct 12, 2010
    This is in preparation of further i810 fixes and switching it to CAR.
    
    Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
    Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
    
    
    
    git-svn-id: svn://coreboot.org/coreboot/trunk@5944 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
  3. We define IO_APIC_ADDR in <arch/ioapic.h>, let's use it.

    uwehermann committed with uwe Oct 12, 2010
    As both ioapic.h and acpi.h define a macro named "NMI", rename one
    of them (NMI -> NMIType in acpi.h).
    
    Abuild-tested.
    
    Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
    Acked-by: Peter Stuge <peter@stuge.se>
    
    
    
    git-svn-id: svn://coreboot.org/coreboot/trunk@5943 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
  4. Reduce duplicate definition in CAR code.

    wt committed with wt Oct 12, 2010
    Macros for the register addresses for the MTRR MSRs are already defined
    in include/cpu/x86/car.h. This patch uses those macros instead of
    creating a second instance of that same data.
    
    I also added a few macros to the amd mtrr.h to make the MSR naming more
    consistent.
    
    Signed-off-by: Warren Turkal <wt@penguintechs.org>
    Acked-by: Stefan Reinauer <stepan@coresystems.de>
    
    git-svn-id: svn://coreboot.org/coreboot/trunk@5942 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
  5. Build bootblock.S instead of bootblock.c.

    wt committed with wt Oct 12, 2010
    The file is actually just including a bunch of assembly. The build rule
    for bootblock.c even states that the file will be "assembler-with-cpp."
    
    Signed-off-by: Warren Turkal <wt@penguintechs.org>
    Acked-by: Stefan Reinauer <stepan@coresystems.de>
    
    git-svn-id: svn://coreboot.org/coreboot/trunk@5941 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
Commits on Oct 11, 2010
  1. Fix typo after r5925.

    Sylvain Hitier committed with uwe Oct 11, 2010
    BTW, embed the always-the-same string instead of referencing it through "%s".
    
    Do the same for i82371EB while we're at it.
    
    Signed-off-by: Sylvain Hitier <sylvain.hitier@gmail.com>
    Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
    
    
    
    git-svn-id: svn://coreboot.org/coreboot/trunk@5940 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
  2. Build fixes (trivial).

    uwehermann committed with uwe Oct 11, 2010
    Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
    Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
    
    
    
    git-svn-id: svn://coreboot.org/coreboot/trunk@5939 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
  3. First round of ICH2/ICH2-M cleanups after split from i82801xx.

    uwehermann committed with uwe Oct 11, 2010
     - Drop all non-ICH2 "struct pci_driver" entries from all files.
    
     - Kconfig: Add missing USE_WATCHDOG_ON_BOOT.
    
     - Drop i82801bx_sata.c and i82801bx_usb_ehci.c, ICH2 doesn't have SATA/EHCI.
    
     - Simplify lots of code, getting rid of i82801xx remainders.
    
     - Use u8 et al (instead of uint8_t) in a few more places.
    
     - Use #defines from header files where possible.
    
     - Various other fixes and updates.
    
    Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
    Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
    
    
    
    git-svn-id: svn://coreboot.org/coreboot/trunk@5938 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
  4. Factor out a few commonly duplicated functions from northbridge.c.

    uwehermann committed with uwe Oct 11, 2010
    The following functions are moved to devices/device_util.c:
    
     - ram_resource()
    
     - tolm_test()
    
     - find_pci_tolm()
    
    There are only two tolm_test() / find_pci_tolm() which differ from the
    defaults, one of them can easily be eliminated in a follow-up patch,
    maybe even both, but for now keep it simple and only eliminate the majority.
    
    Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
    Acked-by: Peter Stuge <peter@stuge.se>
    
    
    
    git-svn-id: svn://coreboot.org/coreboot/trunk@5937 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
Commits on Oct 10, 2010
  1. fix typo in minilzma.cc, found by Idwer.

    Stefan Reinauer committed with stepan Oct 10, 2010
    Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
    Acked-by: Stefan Reinauer <stepan@coresystems.de>
    
    
    
    git-svn-id: svn://coreboot.org/coreboot/trunk@5936 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
  2. don't include unused code, we only need the header.

    Stefan Reinauer committed with stepan Oct 10, 2010
    Acked-by: Stefan Reinauer <stepan@coresystems.de>
    Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
    
    
    
    git-svn-id: svn://coreboot.org/coreboot/trunk@5935 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
  3. fix typos found by zbao in other files.

    Stefan Reinauer committed with stepan Oct 10, 2010
    Signed-off-by: Stefan Reinauer <stepan@coresystems.de>
    Acked-by: Stefan Reinauer <stepan@coresystems.de>
    
    
    
    git-svn-id: svn://coreboot.org/coreboot/trunk@5934 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
  4. Same applies for SB600.

    Rudolf Marek committed with ruik Oct 10, 2010
    Following patch enables UDMA on ALL IDE devices. The current code enables it only for primary master, which causes my DVD drive to fail under windows install
    and even after hard reset in linux (DMA seems lockup).
    
    The fix should not have any influence for Linux because the IDE driver will
    correctly reprogram this bit. 
    
    
    Signed-off-by: Rudolf Marek <r.marek@assembler.cz> 
    Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
    
    
    
    git-svn-id: svn://coreboot.org/coreboot/trunk@5933 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
  5. Following patch fixes the boot_switch_sata_ide logic. It can swap

    Rudolf Marek committed with ruik Oct 10, 2010
    primary / secondary IDE channel with SATA (in IDE mode).
     
    The bug was that setup was done in wrong device.
     
    Signed-off-by: Rudolf Marek <r.marek@assembler.cz>
    Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
    
    
    
    
    git-svn-id: svn://coreboot.org/coreboot/trunk@5932 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
  6. Following patch enables UDMA on ALL IDE devices. The current code ena…

    Rudolf Marek committed with ruik Oct 10, 2010
    …bles it only for primary master, which causes my DVD drive to fail under windows install
    
    and even after hard reset in linux (DMA seems lockup).
    
    The fix should not have any influence for Linux because the IDE driver will
    correctly reprogram this bit. 
    
    Signed-off-by: Rudolf Marek <r.marek@assembler.cz> 
    Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
    
    
    
    git-svn-id: svn://coreboot.org/coreboot/trunk@5931 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
  7. Trivial. Spelling check.

    Zheng Bao committed with zbao Oct 10, 2010
    Signed-off-by: Zheng Bao <zheng.bao@amd.com>
    Acked-by: Zheng Bao <zheng.bao@amd.com>
    
    
    git-svn-id: svn://coreboot.org/coreboot/trunk@5930 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
Commits on Oct 9, 2010
  1. Remove various .c #includes from Intel 440BX/82371EB boards.

    uwehermann committed with uwe Oct 9, 2010
     - Use 'romstage-y' to turn i82371eb_early_pm.c and i82371eb_early_smbus.c
       into distinct compilation units, and don't #include the files anymore
       in romstage.c files.
    
     - Ditto for lib/debug.c, northbridge/intel/i440bx/raminit.c, and
       northbridge/intel/i440bx/debug.c.
    
     - Add various header files which are now needed.
    
     - Make functions that need to be visible non-static.
    
     - Drop a remaining "select ROMCC" from a 4440BX board.
    
    Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
    Acked-by: Idwer Vollering <vidwer@gmail.com>
    
    
    
    git-svn-id: svn://coreboot.org/coreboot/trunk@5929 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
  2. Trivial. Spell checking.

    Zheng Bao committed with zbao Oct 9, 2010
    Signed-off-by: Zheng Bao <zheng.bao@amd.com>
    Acked-by: Zheng Bao <zheng.bao@amd.com>
    
    
    
    git-svn-id: svn://coreboot.org/coreboot/trunk@5928 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
  3. Trivial. Spell checking.

    Zheng Bao committed with zbao Oct 9, 2010
    Signed-off-by: Zheng Bao <zheng.bao@amd.com>
    Acked-by: Zheng Bao <zheng.bao@amd.com>
    
    
    
    git-svn-id: svn://coreboot.org/coreboot/trunk@5927 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
Commits on Oct 8, 2010
  1. Drop unused i82801ax_early_lpc.c and i82801bx_early_lpc.c.

    uwehermann committed with uwe Oct 8, 2010
    Nothing ever calls the functions in these files, and we already have
    i82801ax_watchdog.c and i82801bx_watchdog.c which basically do the same
    _and_ are hooked up correctly in the Makefile.inc and via the
    USE_WATCHDOG_ON_BOOT mechanism.
    
    Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
    Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
    
    
    
    git-svn-id: svn://coreboot.org/coreboot/trunk@5926 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
  2. Round 2 of i82801AX fixes to get it into a usable shape.

    uwehermann committed with uwe Oct 8, 2010
     - Remove left-overs from more generic code in i82801xx times, and fix
       register names as needed.
     
     - Simplify IDE init code (and save some ROM space too).
     
     - Simplify PIRQ code.
     
     - Use u8 et al instead of uint8_t everywhere.
     
     - Random other fixes.
    
    Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
    Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
    
    
    
    git-svn-id: svn://coreboot.org/coreboot/trunk@5925 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
  3. Intel 82801ax/82801bx: Fix and hook up i82801xx_smbus.c.

    uwehermann committed with uwe Oct 8, 2010
     - Fix incorrect #includes, add missing ones.
    
     - Drop unused do_smbus_write_block() and smbus_wait_until_blk_done().
    
     - Pass smbus_io_base to all functions as the other ICH implementations do.
    
     - Random other fixes which are required to make it build.
    
    Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
    Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
    
    
    
    git-svn-id: svn://coreboot.org/coreboot/trunk@5924 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
  4. Trivial. Spell checking.

    Zheng Bao committed with zbao Oct 8, 2010
    Signed-off-by: Zheng Bao <zheng.bao@amd.com>
    Acked-by: Zheng Bao <zheng.bao@amd.com>
    
    
    
    git-svn-id: svn://coreboot.org/coreboot/trunk@5923 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
  5. Trivial. Fix the typo.

    Zheng Bao committed with zbao Oct 8, 2010
    Signed-off-by: Zheng Bao <zheng.bao@amd.com>
    Acked-by: Zheng Bao <zheng.bao@amd.com>
    
    
    
    git-svn-id: svn://coreboot.org/coreboot/trunk@5922 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
Commits on Oct 7, 2010
  1. Remove some duplicate #include files (trivial).

    uwehermann committed with uwe Oct 7, 2010
    Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
    Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
    
    
    
    git-svn-id: svn://coreboot.org/coreboot/trunk@5921 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
  2. Remove duplicate line from pci_ids.h.

    jakllsch committed with myles Oct 7, 2010
    Signed-off-by: Jonathan Kollasch <jakllsch@kollasch.net>
    Acked-by: Jonathan Kollasch <jakllsch@kollasch.net>
    
    
    
    git-svn-id: svn://coreboot.org/coreboot/trunk@5920 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
  3. RS780 function ProgK8TempMmioBase is setting a reserved

    Scott Duplichan committed with ruik Oct 7, 2010
    bit in the AMD processor 'MMIO Limit Address Register'.
    I suspect it is because of a typo where 0x80 was entered
    as 0x8. If 0x80 is used, then the strap configuration
    register accesses become non-posted, which is how the
    Shiner reference BIOS does it.
    
    
    Signed-off-by: Scott Duplichan <scott@notabs.org>
    Acked-by: Rudolf Marek <r.marek@assembler.cz> 
    
    
    
    git-svn-id: svn://coreboot.org/coreboot/trunk@5919 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
  4. Convert all Intel 82371AB/EB/MB based boards to TINY_BOOTBLOCK.

    uwehermann committed with uwe Oct 7, 2010
    Also:
    
    Unfortunately Intel 440BX + 82371AB/EB/MB boards can have their ISA device
    on various PCI bus:device.function locations.
    Examples we encountered: 00:07.0, 00:04.0, or 00:14.0.
    
    Thus, instead of hardcoding PCI bus:device.function numbers such as
    PCI_DEV(0, 7, 0), we now simply find the ISA device via PCI IDs, which
    works the same on all boards.
    
    As an additional benefit this patch also gets rid of one .c file include
    in romstage.c.
    
    Abuild-tested.
    
    Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
    Acked-by: Stefan Reinauer <stepan@coresystems.de>
    
    
    
    git-svn-id: svn://coreboot.org/coreboot/trunk@5918 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
Commits on Oct 6, 2010
  1. Convert all Intel 440BX boards to Cache-as-RAM (CAR).

    uwehermann committed with uwe Oct 6, 2010
     - Add "select CACHE_AS_RAM" in src/cpu/intel/slot_1/Kconfig.
    
     - Add the following in src/cpu/intel/slot_1/Makefile.inc:
       cpu_incs += $(src)/cpu/intel/car/cache_as_ram.inc
    
     - Remove "select ROMCC" from all 440BX board Kconfig files.
    
     - Drop all early_mtrr_init() calls, that's done by CAR code now.
    
    Various small fixes were needed to make it build:
    
     - Drop do_smbus_recv_byte(), do_smbus_send_byte(), do_smbus_write_byte(),
       those were never called anyways.
    
     - Remove the "static" from the main() functions in romstage.c files.
    
     - Always call dump_spd_registers() from the 440BX debug.c, but use
       "#if CONFIG_DEBUG_RAM_SETUP" to only have that code if RAM debugging
       is enabled in menuconfig.
    
     - Drop all "lib/ramtest.c" #includes and ram_check() calls (even if
       commented out) from romstage.c's, as we've done for most other boards.
    
     - Add missing #includes or prototypes. Some of the prototypes will be
       removed later when we get rid of the #include'd .c files.
    
    Abuild-tested for all boards, and boot-tested on A-Trend ATC-6220.
    
    Signed-off-by: Uwe Hermann <uwe@hermann-uwe.de>
    Acked-by: Patrick Georgi <patrick@georgi-clan.de>
    
    
    
    git-svn-id: svn://coreboot.org/coreboot/trunk@5917 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
Commits on Oct 5, 2010
  1. Remove duplicate line from pci_ids.h.

    jakllsch committed with myles Oct 5, 2010
    Signed-off-by: Jonathan Kollasch <jakllsch@kollasch.net>
    Acked-by: Jonathan Kollasch <jakllsch@kollasch.net>
    
    
    
    git-svn-id: svn://coreboot.org/coreboot/trunk@5916 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
  2. Use %p instead of %x to print void *.

    jakllsch committed with myles Oct 5, 2010
    Signed-off-by: Jonathan Kollasch <jakllsch@kollasch.net>
    Acked-by: Jonathan Kollasch <jakllsch@kollasch.net>
    
    
    
    git-svn-id: svn://coreboot.org/coreboot/trunk@5915 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1