Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"aria_" should be handled like "data_" in html_params #239

Closed
MM1nd opened this issue Jan 3, 2016 · 6 comments
Closed

"aria_" should be handled like "data_" in html_params #239

MM1nd opened this issue Jan 3, 2016 · 6 comments
Assignees
Labels
enhancement New feature, or existing feature improvement
Milestone

Comments

@MM1nd
Copy link

MM1nd commented Jan 3, 2016

The title says it. Naturally this can be done by changing

elif k.startswith('data_') 

to

elif k.startswith('data_') or k.startswith('aria_')

but in the long run probably a more sophisticated system might be needed. Maybe a sophisticated implementation already exists.

Related Issue (#48)

Further reference if needed: http://www.w3.org/TR/wai-aria/

Alex

@hammygoonan
Copy link

+1

Further reference here as well: https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA

This is a feature I'd really like to see implemented.

It's now part of Foundation's standard help-text formatting as well http://foundation.zurb.com/sites/docs/forms.html#help-text

@crast crast added the enhancement New feature, or existing feature improvement label Feb 19, 2016
@crast crast added this to the 3.0 milestone Feb 19, 2016
@crast
Copy link
Contributor

crast commented Feb 19, 2016

Good idea. I'm putting it on the schedule for 3.0

@crast crast self-assigned this Feb 19, 2016
@ftm-1
Copy link

ftm-1 commented May 4, 2018

@crast Is this feature anywhere near to being included? I have a PR ready to submit if this is still something you guys want?

@davidism
Copy link
Member

davidism commented May 5, 2018

@ftm-1 I'm the new maintainer. If you have a PR, please submit it! :-)

@ftm
Copy link
Contributor

ftm commented May 10, 2018

Hi @davidism, I was @ftm-1 but now I'm on this account (I managed to get a better username). I have reopened the PR on my new account so it should be ready to go.

@davidism
Copy link
Member

davidism commented Jun 4, 2018

Closed in #389

@davidism davidism closed this as completed Jun 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, or existing feature improvement
Development

No branches or pull requests

6 participants