IPAddress validator return False for valid IPv6 address.

[jirivrany]

Hello,

the address "2001:718:1C01:1111::" is valid IPv6 address, however, the IPAddress validator returns False for it.

[vald-phoenix]

How about to use a default ipaddress module for validation purposes in this case or something like this: socket.inet_pton(socket.AF_INET6, '2001:718:1C01:1111:s:')
What do you think guys?

[davidism]

Yes, I'd like to do that. ipaddress is Python 3 only, although there is a backport we could optionally require on Python 2.

[vald-phoenix]

So we can implement checks by means socket module that available on both versions of Python and reduce the length of the code significantly.

[jirivrany]

I'm using a custom validator based on the ipaddress module as a workaround. But as @davidism says, the Python 2 version would lead to external dependency. If it is not a problem, I can send my code as PR.

[davidism]

The dependency needs to be optional:

try:
    import ipaddress
except ImportError:
    ipaddress = None

class SomeValidator:
    def __init__(self, ...):
        if ipaddress is None:
            raise Exception("Install 'ipaddress' for Python 2 support.")
        ...

PRs welcome.

[jirivrany]

Thanks @davidism then I will prepare one :) I have to rewrite the tests, to fit in the WTForms test suite, because I'm using slightly different environment for my tests.

[davidism]

We're using PyTest now, so feel free to ignore the existing unittest layout, I just haven't got around to rewriting them yet.

[jirivrany]

That's good, because I'm using pytest fixtures and mock. So I will use it in the PR and we can discuss necessary changes later.

[jirivrany]

The PR was created. Please let me know if anything needs to be changed.