Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code breaks on latest release #581

Closed
HarryKodden opened this issue Apr 22, 2020 · 5 comments
Closed

Code breaks on latest release #581

HarryKodden opened this issue Apr 22, 2020 · 5 comments

Comments

@HarryKodden
Copy link

@HarryKodden HarryKodden commented Apr 22, 2020

Actual Behavior

from wtforms.widgets import HTMLString
ImportError: cannot import name 'HTMLString'

Environment

  • Python version: 3.6.8
  • wtforms version: 2.3.0
@spookey
Copy link

@spookey spookey commented Apr 22, 2020

I had the same issue when updating.
HTMLString was replaced with Markup. So use from markupsafe import Markup instead.

Also from wtforms.widgets.core import escape_html was replaced by from markupsafe import escape

@R11baka
Copy link

@R11baka R11baka commented Apr 22, 2020

I had the same issue when running airflow

@azmeuk azmeuk mentioned this issue Apr 22, 2020
Merged
@hatched-DavidMichon
Copy link

@hatched-DavidMichon hatched-DavidMichon commented Apr 22, 2020

Also got this issue

@Jason-Crowe Jason-Crowe mentioned this issue Apr 22, 2020
Merged
@kaxil
Copy link

@kaxil kaxil commented Apr 22, 2020

Is it possible to restore HTMLString and cut 2.3.1 since it specifically said it was a backwards incompatible change in the #400?

@boschmateo boschmateo mentioned this issue Apr 22, 2020
Open
@davidism
Copy link
Member

@davidism davidism commented Apr 22, 2020

Fixed in #583.

kaxil added a commit to astronomer/airflow that referenced this issue Jun 23, 2020
@kaxil
Replace deprecated wtforms HTMLString with markupsafe.MarkUp
ae23e66 
WTForms uses `MarkUp` to escape strings now and removed their internal class HTMLString in Master. Details: wtforms/wtforms#400

That change previously broke Airflow for new users (in 2.3.0). However on users request they added `HTMLString` that just passes all args to `markupsafe.MarkUp` back for temporary Backward compatbility with deprecation warning in 2.3.1. Details: wtforms/wtforms#581
@kaxil kaxil mentioned this issue Jun 23, 2020
Merged
6 tasks
kaxil added a commit to astronomer/airflow that referenced this issue Jun 23, 2020
@kaxil
Replace deprecated wtforms HTMLString with markupsafe.MarkUp
e8932d7 
WTForms uses `MarkUp` to escape strings now and removed their internal class HTMLString in Master. Details: wtforms/wtforms#400

That change previously broke Airflow for new users (in 2.3.0). However on users request they added `HTMLString` that just passes all args to `markupsafe.MarkUp` back for temporary Backward compatbility with deprecation warning in 2.3.1. Details: wtforms/wtforms#581
kaxil added a commit to astronomer/airflow that referenced this issue Jun 23, 2020
@kaxil
Replace deprecated wtforms HTMLString with markupsafe.MarkUp
c8a7c2c 
WTForms uses `MarkUp` to escape strings now and removed their internal class HTMLString in Master. Details: wtforms/wtforms#400

That change previously broke Airflow for new users (in 2.3.0). However on users request they added `HTMLString` that just passes all args to `markupsafe.MarkUp` back for temporary Backward compatbility with deprecation warning in 2.3.1. Details: wtforms/wtforms#581
kaxil added a commit to apache/airflow that referenced this issue Jun 23, 2020
@kaxil
Replace deprecated wtforms HTMLString with markupsafe.MarkUp (#9487)
7c587dc 
WTForms uses `MarkUp` to escape strings now and removed their internal class HTMLString in Master. Details: wtforms/wtforms#400

That change previously broke Airflow for new users (in 2.3.0). However on users request they added `HTMLString` that just passes all args to `markupsafe.MarkUp` back for temporary Backward compatbility with deprecation warning in 2.3.1. Details: wtforms/wtforms#581
kaxil added a commit to kaxil/airflow that referenced this issue Jun 27, 2020
@kaxil
Replace deprecated wtforms HTMLString with markupsafe.MarkUp (apache#…
6c749a2 
…9487)

WTForms uses `MarkUp` to escape strings now and removed their internal class HTMLString in Master. Details: wtforms/wtforms#400

That change previously broke Airflow for new users (in 2.3.0). However on users request they added `HTMLString` that just passes all args to `markupsafe.MarkUp` back for temporary Backward compatbility with deprecation warning in 2.3.1. Details: wtforms/wtforms#581
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue Sep 15, 2021
@kaxil
Replace deprecated wtforms HTMLString with markupsafe.MarkUp (#9487)
76f7a86 
WTForms uses `MarkUp` to escape strings now and removed their internal class HTMLString in Master. Details: wtforms/wtforms#400

That change previously broke Airflow for new users (in 2.3.0). However on users request they added `HTMLString` that just passes all args to `markupsafe.MarkUp` back for temporary Backward compatbility with deprecation warning in 2.3.1. Details: wtforms/wtforms#581

GitOrigin-RevId: 7c587dc486c4f637c681e2e8b61a12ebf99c0f14
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue Sep 17, 2021
@kaxil
Replace deprecated wtforms HTMLString with markupsafe.MarkUp (#9487)
fa18e5a 
WTForms uses `MarkUp` to escape strings now and removed their internal class HTMLString in Master. Details: wtforms/wtforms#400

That change previously broke Airflow for new users (in 2.3.0). However on users request they added `HTMLString` that just passes all args to `markupsafe.MarkUp` back for temporary Backward compatbility with deprecation warning in 2.3.1. Details: wtforms/wtforms#581

GitOrigin-RevId: 7c587dc486c4f637c681e2e8b61a12ebf99c0f14
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue Sep 23, 2021
@kaxil
Replace deprecated wtforms HTMLString with markupsafe.MarkUp (#9487)
3dcd1f9 
WTForms uses `MarkUp` to escape strings now and removed their internal class HTMLString in Master. Details: wtforms/wtforms#400

That change previously broke Airflow for new users (in 2.3.0). However on users request they added `HTMLString` that just passes all args to `markupsafe.MarkUp` back for temporary Backward compatbility with deprecation warning in 2.3.1. Details: wtforms/wtforms#581

GitOrigin-RevId: 7c587dc486c4f637c681e2e8b61a12ebf99c0f14
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue Nov 25, 2021
@kaxil
Replace deprecated wtforms HTMLString with markupsafe.MarkUp (#9487)
8d0f0a9 
WTForms uses `MarkUp` to escape strings now and removed their internal class HTMLString in Master. Details: wtforms/wtforms#400

That change previously broke Airflow for new users (in 2.3.0). However on users request they added `HTMLString` that just passes all args to `markupsafe.MarkUp` back for temporary Backward compatbility with deprecation warning in 2.3.1. Details: wtforms/wtforms#581

GitOrigin-RevId: 7c587dc486c4f637c681e2e8b61a12ebf99c0f14
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue Mar 9, 2022
@kaxil
Replace deprecated wtforms HTMLString with markupsafe.MarkUp (#9487)
192ab1b 
WTForms uses `MarkUp` to escape strings now and removed their internal class HTMLString in Master. Details: wtforms/wtforms#400

That change previously broke Airflow for new users (in 2.3.0). However on users request they added `HTMLString` that just passes all args to `markupsafe.MarkUp` back for temporary Backward compatbility with deprecation warning in 2.3.1. Details: wtforms/wtforms#581

GitOrigin-RevId: 7c587dc486c4f637c681e2e8b61a12ebf99c0f14
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue Jun 3, 2022
@kaxil
Replace deprecated wtforms HTMLString with markupsafe.MarkUp (#9487)
c396334 
WTForms uses `MarkUp` to escape strings now and removed their internal class HTMLString in Master. Details: wtforms/wtforms#400

That change previously broke Airflow for new users (in 2.3.0). However on users request they added `HTMLString` that just passes all args to `markupsafe.MarkUp` back for temporary Backward compatbility with deprecation warning in 2.3.1. Details: wtforms/wtforms#581

GitOrigin-RevId: 7c587dc486c4f637c681e2e8b61a12ebf99c0f14
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue Jun 6, 2022
@kaxil
Replace deprecated wtforms HTMLString with markupsafe.MarkUp (#9487)
d8ab78d 
WTForms uses `MarkUp` to escape strings now and removed their internal class HTMLString in Master. Details: wtforms/wtforms#400

That change previously broke Airflow for new users (in 2.3.0). However on users request they added `HTMLString` that just passes all args to `markupsafe.MarkUp` back for temporary Backward compatbility with deprecation warning in 2.3.1. Details: wtforms/wtforms#581

GitOrigin-RevId: 7c587dc486c4f637c681e2e8b61a12ebf99c0f14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@R11baka @spookey @davidism @HarryKodden @kaxil @hatched-DavidMichon