/wtforms

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

field.process_formdata should still be called if formdata is empty #280

Merged
merged 1 commit into from Jul 15, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
1 participant
@davidism
@davidism
Member

davidism commented Jun 22, 2016

Some fields will set a default value if their key is not in formdata. However, process_formdata is only called if formdata is truthy. This can cause unexpected field data if formdata is empty versus if it just didn't contain the field.

class F(Form):
    name = StringField()

f = F(MultiDict())
print(f.name.data)  # None

f = F(MultiDict({'language': 'Python'}))
print(f.name.data)  # ''

This patch explicitly checks if formdata is None and adds a test for this case.

@davidism davidism referenced this pull request Jun 22, 2016

Merged

Add support for multiple file input #281

@davidism davidism merged commit cbf70af into wtforms:master Jul 15, 2016
2 checks passed

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 99.694%
Details

@davidism davidism deleted the davidism:process_empty_formdata branch Jul 15, 2016

ftm pushed a commit to ftm/wtforms that referenced this pull request May 10, 2018

@davidism
call field.process_formdata even if formdata is empty (wtforms#280)
6ff8bda

davidism added a commit that referenced this pull request May 11, 2018

@davidism
call field.process_formdata even if formdata is empty (#280)
Verified
This commit was signed with a verified signature.
@davidism davidism David Lord
GPG key ID: 7A1C87E3F5BC42A8 Learn about signing commits
7575a92

@abulte abulte referenced this pull request Jun 4, 2018

Merged

Update wtforms to 2.2 #1713

This was referenced Jun 6, 2018

Closed
Merged
Open

ewdurbin added a commit to pypa/warehouse that referenced this pull request Jun 13, 2018

@ewdurbin
fix for wtforms==2.2.1 
wtforms/wtforms#280 did away with the behavior that was exposing the `None` in this scenario
Verified
This commit was signed with a verified signature.
@ewdurbin ewdurbin Ernest W. Durbin III
GPG key ID: 4F19322DF3FFA2D5 Learn about signing commits
Loading status checks…
f9e1b68

ewdurbin added a commit to pypa/warehouse that referenced this pull request Jun 13, 2018

@pyup-bot @ewdurbin
Update wtforms to 2.2.1 (#4141) 
* Update wtforms from 2.1 to 2.2.1

* fix for wtforms==2.2.1

wtforms/wtforms#280 did away with the behavior that was exposing the `None` in this scenario
Loading status checks…
680d9f4

netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Nov 12, 2018

@kleink
py-wtforms: Update to 2.2.1. 
Version 2.2.1
-------------

Released on June 7th, 2018

-   :class:`~fields.StringField` only sets ``data = ''`` when form data
    is empty and an initial value was not provided. This fixes an issue
    where the default value wasn't rendered with the initial form.
    (`#291`_, `#401`_)

.. _#291: wtforms/wtforms#291
.. _#401: wtforms/wtforms#401


Version 2.2
-----------

Released on June 2nd, 2018

-   Merged new and updated translations from the community.
-   Passing ``data_`` args to render a field converts all the
    underscores to hyphens when rendering the HTML attribute, not just
    the first one. ``data_foo_bar`` becomes ``data-foo-bar``. (`#248`_)
-   The :class:`~validators.UUID` validator uses the :class:`uuid.UUID`
    class instead of a regex. (`#251`_)
-   :class:`~fields.SelectField` copies the list of ``choices`` passed
    to it so modifying an instance's choices will not modify the global
    form definition. (`#286`_)
-   Fields call :meth:`~fields.Field.process_formdata` even if the raw
    data is empty. (`#280`_)
-   Added a :class:`~fields.MultipleFileField` to handle a multi-file
    input. :class:`~fields.FileField` continues to handle only one
    value. The underlying :class:`~widgets.FileInput` widget gained a
    ``multiple`` argument. (`#281`_)
-   :class:`~fields.SelectField` choices can contain HTML (MarkupSafe
    ``Markup`` object or equivalent API) and will be rendered properly.
    (`#302`_)
-   :class:`~fields.TimeField` and
    :class:`html5.TimeField <fields.html5.TimeField>` were added.
    (`#254`_)
-   Improved :class:`~validators.Email`. Note that it is still
    unreasonable to validate all emails with a regex and you should
    prefer validating by actually sending an email. (`#294`_)
-   Widgets render the ``required`` attribute when using a validator
    that provides the ``'required'`` flag, such as
    :class:`~validators.DataRequired`. (`#361`_)
-   Fix a compatibility issue with SQLAlchemy 2.1 that caused
    :class:`~ext.sqlalchemy.fields.QuerySelectField` to fail with
    ``ValueError: too many values to unpack``. (`#391`_)

.. _#248: wtforms/wtforms#248
.. _#251: wtforms/wtforms#251
.. _#254: wtforms/wtforms#254
.. _#280: wtforms/wtforms#280
.. _#281: wtforms/wtforms#281
.. _#286: wtforms/wtforms#286
.. _#294: wtforms/wtforms#294
.. _#302: wtforms/wtforms#302
.. _#361: wtforms/wtforms#361
.. _#391: wtforms/wtforms#391
00227fc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment