IntegerField should check type when process data #451
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Core fields like
IntegerField
will check type onprocess_formdata
by reload from baseField
, but not check onprocess_data
in current version. If we pass unsupported type indata
forForm
, like a string 'x', the form won't raise any error and will pass the origin string as value for user, it doesn't make sense for this case.As
BooleanField
did inprocess_data
,IntegerField
should do the same thing, so I add the progress and test case forIntegerField
.Maybe other fields in
fields/core.py
likeFloatField
should do type check inprogress_data
also.