Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python 2, 3.4, 3.5 #554

Merged
merged 15 commits into from Apr 21, 2020
Merged

Drop Python 2, 3.4, 3.5 #554

merged 15 commits into from Apr 21, 2020

Conversation

azmeuk
Copy link
Member

@azmeuk azmeuk commented Apr 17, 2020

Should fix #552

@azmeuk azmeuk force-pushed the python2-eol branch 6 times, most recently from 2f0cfa4 to a14e467 Compare April 18, 2020 13:07
@davidism
Copy link
Member

We can also remove 3.5, using pyupgrade --py36-plus hits most of it, but f-string conversion doesn't catch all the cases so I usually do some manual search and cleanup.

@azmeuk
Copy link
Member Author

azmeuk commented Apr 20, 2020

Python 3.5 is still supported until 2020-09-13.
Don't you think it worth waiting a few months before dropping py35 support?

@davidism
Copy link
Member

We decided with Pallets to just drop it early.

@davidism
Copy link
Member

Since this is in master, 2.3 will still support the old versions, so people will have a relatively updated version to use if they can't upgrade. I'm fine with dropping 3.5 in master.

@azmeuk
Copy link
Member Author

azmeuk commented Apr 20, 2020

Fair enough :)

@azmeuk azmeuk force-pushed the python2-eol branch 3 times, most recently from dce6933 to d5ef87a Compare April 20, 2020 15:34
@azmeuk
Copy link
Member Author

azmeuk commented Apr 20, 2020

Done.

@davidism davidism changed the title Removed support for python2 and python34 Drop Python 2, 3.4, 3.5 Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

End python2 support
2 participants