Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd Windows support #253
Conversation
mdlawson
added some commits
Jan 12, 2014
wting
reviewed
Jan 15, 2014
wting
reviewed
Jan 15, 2014
wting
reviewed
Jan 15, 2014
| icon_dir = os.path.join(args.destdir, args.prefix, 'share/autojump') | ||
| etc_dir = os.path.join(args.destdir, 'etc', 'profile.d') | ||
| doc_dir = os.path.join(args.destdir, args.prefix, 'share', 'man', 'man1') | ||
| icon_dir = os.path.join(args.destdir, args.prefix, 'share', 'autojump') |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
wting
reviewed
Jan 15, 2014
wting
reviewed
Jan 15, 2014
wting
reviewed
Jan 15, 2014
| @@ -8,6 +8,7 @@ | ||
| import shutil | ||
| import sys | ||
| sys.path.append('bin') |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
wting
reviewed
Jan 15, 2014
wting
reviewed
Jan 15, 2014
wting
reviewed
Jan 15, 2014
wting
reviewed
Jan 15, 2014
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
wting
Jan 15, 2014
Owner
Also you might want to look into using a linter (autojump has config settings for flake8. It's just some minor stuff like non-multiple of 4 indents and missing spaces.
|
Also you might want to look into using a linter (autojump has config settings for flake8. It's just some minor stuff like non-multiple of 4 indents and missing spaces. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
wting
Jan 15, 2014
Owner
This is fine if you don't feel like doing it, but your shell wrapper doesn't redirect autojump errors to an errors.log file.
|
This is fine if you don't feel like doing it, but your shell wrapper doesn't redirect autojump errors to an errors.log file. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
mdlawson
Jan 15, 2014
Contributor
I'll fix everything else up soon. I'll add custom install and error logging back in as well.
Sorry for the errors/sloppy formatting.
|
I'll fix everything else up soon. I'll add custom install and error logging back in as well. Sorry for the errors/sloppy formatting. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Not at all, thanks for all your work so far! |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
mdlawson
Jan 16, 2014
Contributor
Should be OK now. Not sure how strict to be about the 80 char line length limits, but its probably best for someone more familiar with python style to cut things off where appropriate.
|
Should be OK now. Not sure how strict to be about the 80 char line length limits, but its probably best for someone more familiar with python style to cut things off where appropriate. |
wting
merged commit ff9376c
into
wting:master
Jan 18, 2014
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Thanks! |
mdlawson commentedJan 13, 2014
This patch adds (native, no cygwin/mingw) support for windows to autojump, using clink to hook on directory changes. All the main functions have been ported, but completion has not yet been added. Most installation types are not supported, only user installation, though I could add them. Errors are also not logged, though it can probably be added. I was just looking to get a functional base working.
Not sure if this is something you'd want to merge, but I'm definitely already enjoying having autojump on windows.