From 1d116e29a413baa7f9246e4634e427f35592c9d8 Mon Sep 17 00:00:00 2001 From: mgcam Date: Thu, 4 Apr 2024 17:59:48 +0100 Subject: [PATCH] Fixed the SeqQC pulldown metrics display bug (#858) This was introduced while updating the SeqQC summary display for pulldown_metrics incomplete results. The bug manifestation is a display appearance of an unexpected raw mean depth value just before the coverage value. Also, display proper metrics for zero coverage --- Changes | 5 +++++ npg_qc_viewer/root/src/ui_lanes/lane.tt2 | 4 ++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/Changes b/Changes index 84d815b5..dda234a0 100644 --- a/Changes +++ b/Changes @@ -1,5 +1,10 @@ LIST OF CHANGES FOR NPG-QC PACKAGE + - Fixed the bug that was introduced while updating the SeqQC summary display + for pulldown_metrics incomplete results. The bug manifestation is a display + appearence of an unexpected raw mean depth value just before the coverage + value. All values that should be displayed were unaffected by the bug. + release 72.0.1 - Ensured that retrieving values from a partially defined pulldown_metrics result does not trigger an error. Added a test to demonstrate that such diff --git a/npg_qc_viewer/root/src/ui_lanes/lane.tt2 b/npg_qc_viewer/root/src/ui_lanes/lane.tt2 index 52407fad..8ff59324 100644 --- a/npg_qc_viewer/root/src/ui_lanes/lane.tt2 +++ b/npg_qc_viewer/root/src/ui_lanes/lane.tt2 @@ -425,7 +425,7 @@ END [% href='#pdmc_' _ result.id_run _ ':' _ result.position _ ':' _ result.tag_index %] [%- - mcoverage; + mcoverage = -1; IF result.unique_bases_aligned_num.defined && result.unique_bases_aligned_num != 0; mcoverage = result.mean_target_coverage / (result.unique_bases_aligned_num / 1000000000); END; @@ -439,7 +439,7 @@ END END; coverage = result.target_bases_coverage_percent.20 ? result.target_bases_coverage_percent.20 : 0; -%] -[% IF mcoverage.defined %] +[% IF mcoverage >= 0 %] [% IF result.interval_files_identical.defined && result.interval_files_identical == 1 %] NA      NA
 [% FILTER format('%2.2f');on_bait;END %]