[pull] master from php:master #697
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* PHP-8.3: Fix memory leak in openssl_sign() when passing invalid algorithm
* PHP-8.4: Fix memory leak in openssl_sign() when passing invalid algorithm
This regressed in 62c7432, prior to that commit the value was set to false in case random number generation failed, but now even if an exception is thrown it is set to true. This likely does not _really_ matter as the user will handle the exception, still the value in $strong_result is observable.
This calls php_openssl_store_errors() in the success path right now, change it to call php_openssl_store_errors() in the error path.
* PHP-8.3: Fix inverted call to php_openssl_store_errors() Fix openssl_random_pseudo_bytes() always setting strong_result to true
* PHP-8.4: Fix inverted call to php_openssl_store_errors() Fix openssl_random_pseudo_bytes() always setting strong_result to true
* PHP-8.3: Fix resource leak in iptcembed() on error
* PHP-8.4: Fix resource leak in iptcembed() on error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )