Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit the front page changes #151

Merged
merged 1 commit into from Feb 8, 2020
Merged

Conversation

@GindaChen
Copy link
Contributor

GindaChen commented Feb 8, 2020

Fix #149

@Atena1118 See if that's what you request...

To be honest, I now understand how hard it is to search the js and edit the fields. It is really painful.

I vote for establishing a sheet-like file to capture these information. CSV, using the table in markdown, whatever. Programmer should maintain the key relation of the fields, and the translators will be able to edit that once changed.

I will see if that could happen.

Ginda Chen
@GindaChen GindaChen requested a review from chenrui333 Feb 8, 2020
@GindaChen

This comment has been minimized.

Copy link
Contributor Author

GindaChen commented Feb 8, 2020

Let's merge for now. I will discuss with @Atena1118 when she wakes up

@chenrui333

This comment has been minimized.

Copy link
Member

chenrui333 commented Feb 8, 2020

I vote for establishing a sheet-like file to capture these information. CSV, using the table in markdown, whatever. Programmer should maintain the key relation of the fields, and the translators will be able to edit that once changed.

that sounds like a feature for docsite

cc @lovepoem @purple-force

@GindaChen GindaChen merged commit e1f89b8 into dev Feb 8, 2020
3 checks passed
3 checks passed
audit
Details
Build (8.x)
Details
calibreapp/image-actions calibreapp/image-actions
Details
@chenrui333

This comment has been minimized.

Copy link
Member

chenrui333 commented Feb 8, 2020

Sounds good!

@chenrui333 chenrui333 deleted the gindachen-atena118-italian-metadata-update branch Feb 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.