Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix site metadata for French #157

Merged
merged 1 commit into from Feb 8, 2020
Merged

Fix site metadata for French #157

merged 1 commit into from Feb 8, 2020

Conversation

@GindaChen
Copy link
Contributor

GindaChen commented Feb 8, 2020

Fix #156

Ginda Chen
@GindaChen GindaChen requested a review from chenrui333 Feb 8, 2020
@GindaChen GindaChen requested a review from wuhan2020/team-translate as a code owner Feb 8, 2020
@GindaChen GindaChen merged commit 3d38fed into dev Feb 8, 2020
3 checks passed
3 checks passed
audit audit
Details
Build (8.x)
Details
calibreapp/image-actions calibreapp/image-actions
Details
@GindaChen

This comment has been minimized.

Copy link
Contributor Author

GindaChen commented Feb 8, 2020

(I think the GithubDesktop has a bug -- if I switch branch, the most recent PR will be merged ...

key: 'mis',
text: '2019-NCOV INFORMATION PLATFORM',
link: 'https://wuhan2020.kaiyuanshe.cn',
Comment on lines +422 to +424

This comment has been minimized.

Copy link
@chenrui333

chenrui333 Feb 8, 2020

Member

这里是有问题的

This comment has been minimized.

Copy link
@GindaChen

GindaChen Feb 8, 2020

Author Contributor

I haven't understand the problem yet... What is the problem here?

This comment has been minimized.

Copy link
@chenrui333

chenrui333 Feb 8, 2020

Member

code style issue, indentation problem

list: [
{
text: 'Wuhan2020 项目是干什么的?',
text: 'What is Wuhan2020?',

This comment has been minimized.

Copy link
@chenrui333

chenrui333 Feb 8, 2020

Member

你这里应该是法语翻译。

link: '/fr-fr/docs/overview/what-is-wuhan2020.html',
},
{
text: '快速开始',
text: 'Quick Start',

This comment has been minimized.

Copy link
@chenrui333

chenrui333 Feb 8, 2020

Member

你这里应该是法语翻译。

@chenrui333 chenrui333 deleted the gindachen-fix-french-metadata branch Feb 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.