Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

项目列表页面改善 #176

Merged
merged 3 commits into from Feb 9, 2020
Merged

项目列表页面改善 #176

merged 3 commits into from Feb 9, 2020

Conversation

@shawnpanda
Copy link
Contributor

shawnpanda commented Feb 9, 2020

Followup of #170

Changes:

  1. Removed all download.md because the project pages now are live
  2. Added docs on how to add new project showcases
  3. Fixed a minor typo in docs

Question from me:
Even after I deleted those download.md files, running locally and the site http://127.0.0.1:8080/zh-cn/blog/download.html is still accessible (which reads from those md files). Why is that?

@shawnpanda shawnpanda requested a review from wuhan2020/team-translate as a code owner Feb 9, 2020
@iLtc
iLtc approved these changes Feb 9, 2020
Copy link
Member

iLtc left a comment

Looks good to me. Thanks!

@iLtc

This comment has been minimized.

Copy link
Member

iLtc commented Feb 9, 2020

@shawnpanda It's because the [lang-code]/blog/download.html files had been generated before and won't be removed automatically by the builder.

If you want, you can remove all the [lang-code] folders from your root directory (not from blog or docs folder!!!) and build the project again. The files should not be generated again.

Copy link
Member

chenrui333 left a comment

lgtm

@lovepoem lovepoem merged commit a2b36c4 into wuhan2020:dev Feb 9, 2020
4 checks passed
4 checks passed
Build (8.x)
Details
calibreapp/image-actions calibreapp/image-actions
Details
DeepScan 0 new and 0 fixed issues
Details
codebeat no reportable quality changes
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.